Page MenuHomeFreeBSD
Differential D54551

smp: add smp_rendezvous_cpu helper function
ClosedPublic
Actions

Authored by aokblast on Jan 6 2026, 4:00 AM.
Tags
None
Referenced Files
F164624325: D54551.id169155.diff
Sun, Aug 2, 3:08 PM
Unknown Object (File)
Sun, Jul 26, 8:37 PM
Unknown Object (File)
Sat, Jul 25, 8:15 PM
Unknown Object (File)
Fri, Jul 24, 6:43 PM
Unknown Object (File)
Thu, Jul 23, 2:04 AM
Unknown Object (File)
Wed, Jul 22, 7:10 AM
Unknown Object (File)
Tue, Jul 21, 7:27 PM
Unknown Object (File)
Tue, Jul 21, 1:57 PM
View All 75 Files
Subscribers
imp
olce

Details

Reviewers
olce
markj
lwhsu
Commits
rG5b61ef94d65a: smp: add smp_rendezvous_cpu helper function

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 69649
Build 66532: arc lint + arc unit

Event Timeline

aokblast created this revision.Jan 6 2026, 4:00 AM
Herald added subscribers: olce, imp. · View Herald TranscriptJan 6 2026, 4:00 AM
aokblast requested review of this revision.Jan 6 2026, 4:00 AM
Harbormaster completed remote builds in B69647: Diff 169153.Jan 6 2026, 4:00 AM
aokblast updated this revision to Diff 169155.Jan 6 2026, 4:06 AM

Move commit back

Harbormaster completed remote builds in B69649: Diff 169155.Jan 6 2026, 4:06 AM
aokblast added a child revision: D54505: hwpstate_amd: Use ipi instead of sched_bind + thread_lock.Jan 6 2026, 4:07 AM
olce accepted this revision.Jan 6 2026, 9:01 AM

Indentation of continuation lines for arguments is not as per style(9) (4 spaces, not a 8-space TAB), but consistent with some other smp_rendezvous_*() functions, so I'm fine with that (and these could all be fixed in a subsequent commit).

This revision is now accepted and ready to land.Jan 6 2026, 9:01 AM
aokblast added reviewers: markj, lwhsu.Jan 10 2026, 8:39 AM
markj accepted this revision.Jan 11 2026, 11:52 PM

Looks ok, but I'd use int in the function signature.

sys/kern/subr_smp.c
628

The cpuid type is usually int (see ipi_cpu() for instance) or u_int, we should follow that convention instead of using a fixed-width type.

Closed by commit rG5b61ef94d65a: smp: add smp_rendezvous_cpu helper function (authored by aokblast). · Explain WhyJan 16 2026, 2:39 PM
This revision was automatically updated to reflect the committed changes.
aokblast added a commit: rG5b61ef94d65a: smp: add smp_rendezvous_cpu helper function.
aokblast added a comment.Jan 16 2026, 2:40 PM
In D54551#1248714, @markj wrote:

Looks ok, but I'd use int in the function signature.

I use u_int since pcpu->cpuid is u_int.

Revision Contents
Changeset List

PathSize
sys/
kern/
13 lines
sys/
7 lines

Diff 169155

View Options

sys/kern/subr_smp.c

Loading...
View Options

sys/sys/smp.h

Loading...