Page MenuHomeFreeBSD

smp: add smp_rendezvous_cpu helper function
AcceptedPublic

Authored by aokblast on Tue, Jan 6, 4:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 14, 10:32 AM
Unknown Object (File)
Tue, Jan 13, 1:21 PM
Unknown Object (File)
Tue, Jan 13, 10:58 AM
Unknown Object (File)
Tue, Jan 13, 2:39 AM
Unknown Object (File)
Mon, Jan 12, 11:15 PM
Unknown Object (File)
Sun, Jan 11, 9:52 PM
Unknown Object (File)
Sat, Jan 10, 4:43 PM
Unknown Object (File)
Sat, Jan 10, 4:29 PM
Subscribers

Details

Reviewers
olce
markj
lwhsu

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 69649
Build 66532: arc lint + arc unit

Event Timeline

Indentation of continuation lines for arguments is not as per style(9) (4 spaces, not a 8-space TAB), but consistent with some other smp_rendezvous_*() functions, so I'm fine with that (and these could all be fixed in a subsequent commit).

This revision is now accepted and ready to land.Tue, Jan 6, 9:01 AM

Looks ok, but I'd use int in the function signature.

sys/kern/subr_smp.c
628

The cpuid type is usually int (see ipi_cpu() for instance) or u_int, we should follow that convention instead of using a fixed-width type.