Page MenuHomeFreeBSD
Differential D54174

sound: Do not check for NULL before free()
ClosedPublic
Actions

Authored by christos on Dec 11 2025, 11:17 AM.
Tags
None
Referenced Files
F166807735: D54174.id168890.diff
Sun, Aug 16, 7:54 PM
Unknown Object (File)
Thu, Aug 13, 7:03 PM
Unknown Object (File)
Thu, Aug 13, 6:35 PM
Unknown Object (File)
Thu, Aug 13, 2:16 PM
Unknown Object (File)
Wed, Aug 12, 8:14 AM
Unknown Object (File)
Tue, Aug 11, 11:45 PM
Unknown Object (File)
Tue, Aug 11, 11:35 PM
Unknown Object (File)
Tue, Aug 11, 11:31 PM
View All 64 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rG4fc99fc60def: sound: Do not check for NULL before free()
rG792251295cdf: sound: Do not check for NULL before free()
Summary

No functional change intended.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69177
Build 66060: arc lint + arc unit

Event Timeline

christos created this revision.Dec 11 2025, 11:17 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 11 2025, 11:17 AM
christos requested review of this revision.Dec 11 2025, 11:17 AM
Harbormaster completed remote builds in B69176: Diff 167862.Dec 11 2025, 11:17 AM
markj added inline comments.Dec 11 2025, 2:07 PM
sys/dev/sound/pci/envy24.c
629

Presumably you still need to check this condition?

sys/dev/sound/pci/envy24ht.c
710

Same here.

christos updated this revision to Diff 167864.Dec 11 2025, 2:11 PM
christos marked 2 inline comments as done.

Address Mark's comments.

Harbormaster completed remote builds in B69177: Diff 167864.Dec 11 2025, 2:11 PM
markj accepted this revision.Dec 11 2025, 2:17 PM
This revision is now accepted and ready to land.Dec 11 2025, 2:17 PM
Closed by commit rG792251295cdf: sound: Do not check for NULL before free() (authored by christos). · Explain WhyJan 2 2026, 4:59 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG792251295cdf: sound: Do not check for NULL before free().
christos added a commit: rG4fc99fc60def: sound: Do not check for NULL before free().Jan 9 2026, 11:28 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
3 lines
fdt/
6 lines
midi/
6 lines
pci/
3 lines
6 lines
6 lines
3 lines
12 lines
12 lines
3 lines
2 lines
pcm/
19 lines
3 lines
3 lines
3 lines
3 lines
3 lines
37 lines
3 lines
usb/
6 lines

Diff 167864

View Options

sys/dev/sound/dummy.c

Loading...
View Options

sys/dev/sound/fdt/audio_soc.c

Loading...
View Options

sys/dev/sound/midi/midi.c

Loading...
View Options

sys/dev/sound/pci/cmi.c

Loading...
View Options

sys/dev/sound/pci/envy24.c

Loading...
View Options

sys/dev/sound/pci/envy24ht.c

Loading...
View Options

sys/dev/sound/pci/es137x.c

Loading...
View Options

sys/dev/sound/pci/hdsp-pcm.c

Loading...
View Options

sys/dev/sound/pci/hdspe-pcm.c

Loading...
View Options

sys/dev/sound/pci/via8233.c

Loading...
View Options

sys/dev/sound/pci/via82c686.c

Loading...
View Options

sys/dev/sound/pcm/buffer.c

Loading...
View Options

sys/dev/sound/pcm/dsp.c

Loading...
View Options

sys/dev/sound/pcm/feeder_eq.c

Loading...
View Options

sys/dev/sound/pcm/feeder_format.c

Loading...
View Options

sys/dev/sound/pcm/feeder_matrix.c

Loading...
View Options

sys/dev/sound/pcm/feeder_mixer.c

Loading...
View Options

sys/dev/sound/pcm/feeder_rate.c

Loading...
View Options

sys/dev/sound/pcm/feeder_volume.c

Loading...
View Options

sys/dev/sound/usb/uaudio.c

Loading...