vmm: Deduplicate VM and vCPU state management code
ClosedPublic
Actions

Authored by markj on Nov 4 2025, 4:40 PM.

Details

Reviewers

andrew
manu

Group Reviewers

bhyve

Commits

rGed85203fb7a0: vmm: Deduplicate VM and vCPU state management code

Summary

Now that the machine-independent fields of struct vm and struct vcpu are
available in a header, we can move lots of duplicated code into
sys/dev/vmm/vmm_vm.c. This change does exactly that.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68416
Build 65299: arc lint + arc unit

Event Timeline

markj created this revision.Nov 4 2025, 4:40 PM

Herald added a reviewer: andrew. · View Herald TranscriptNov 4 2025, 4:40 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, bcran, rgrimes and 2 others. · View Herald Transcript

markj requested review of this revision.Nov 4 2025, 4:40 PM

markj added a parent revision: D53584: vmm: Consolidate vm and vcpu definitions.

Harbormaster completed remote builds in B68416: Diff 165837.Nov 4 2025, 4:40 PM

markj added a child revision: D53586: vmm: Move common accessors and vm_eventinfo into sys/dev/vmm.Nov 4 2025, 4:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jan 8, 9:58 PM

Closed by commit rGed85203fb7a0: vmm: Deduplicate VM and vCPU state management code (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGed85203fb7a0: vmm: Deduplicate VM and vCPU state management code.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

include/

vmm.h

37 lines

vmm/

io/

1 line

1 line

483 lines

1 line

1 line

arm64/

include/

vmm.h

26 lines

vmm/

io/

vgic_v3.c

1 line

vmm.c

317 lines

dev/

vmm/

vmm_dev.c

32 lines

vmm_vm.h

49 lines

vmm_vm.c

476 lines

modules/

vmm/

Makefile

3 lines

riscv/

include/

vmm.h

28 lines

vmm/

317 lines

1 line

2 lines

2 lines

Diff 165837

View Options

sys/amd64/include/vmm.h

View Options

sys/amd64/vmm/io/vioapic.c

View Options

sys/amd64/vmm/io/vlapic.c

View Options

sys/amd64/vmm/vmm.c

View Options

sys/amd64/vmm/vmm_lapic.c

View Options

sys/amd64/vmm/x86.c

View Options

sys/arm64/include/vmm.h

View Options

sys/arm64/vmm/io/vgic_v3.c

View Options

sys/arm64/vmm/vmm.c

View Options

sys/dev/vmm/vmm_dev.c

View Options

sys/dev/vmm/vmm_vm.h

View Options

sys/dev/vmm/vmm_vm.c

View Options

sys/modules/vmm/Makefile

View Options

sys/riscv/include/vmm.h

View Options

sys/riscv/vmm/vmm.c

View Options

sys/riscv/vmm/vmm_aplic.c

View Options

sys/riscv/vmm/vmm_sbi.c

View Options

sys/riscv/vmm/vmm_vtimer.c

vmm: Deduplicate VM and vCPU state management codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 165837

sys/amd64/include/vmm.h

sys/amd64/vmm/io/vioapic.c

sys/amd64/vmm/io/vlapic.c

sys/amd64/vmm/vmm.c

sys/amd64/vmm/vmm_lapic.c

sys/amd64/vmm/x86.c

sys/arm64/include/vmm.h

sys/arm64/vmm/io/vgic_v3.c

sys/arm64/vmm/vmm.c

sys/dev/vmm/vmm_dev.c

sys/dev/vmm/vmm_vm.h

sys/dev/vmm/vmm_vm.c

sys/modules/vmm/Makefile

sys/riscv/include/vmm.h

sys/riscv/vmm/vmm.c

sys/riscv/vmm/vmm_aplic.c

sys/riscv/vmm/vmm_sbi.c

sys/riscv/vmm/vmm_vtimer.c

vmm: Deduplicate VM and vCPU state management code
ClosedPublic
Actions

Revision Contents
Changeset List