compat: linux: use appropriate variables for copying out old timers
ClosedPublic
Actions

Authored by kevans on Oct 8 2025, 7:39 PM.

Details

Reviewers

dchagin
markj
vexeduxr

Commits

rG958f2ab6d400: compat: linux: use appropriate variables for copying out old timers
rG0c5ac3e46e78: compat: linux: use appropriate variables for copying out old timers
rG7d0243317f3a: compat: linux: use appropriate variables for copying out old timers
rG541a98d7e28a: compat: linux: use appropriate variables for copying out old timers

Summary

We copyout &l_oval but do the conversions into &l_val, leaving us with
stack garbage. A build with an LLVM21 cross-toolchain seems to catch
this.

Reported by: Florian Limberger <flo purplekraken com>
Fixes: a1fd2911ddb06 ("linux(4): Implement timer_settime64 syscall.")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67647
Build 64530: arc lint + arc unit

Event Timeline

kevans created this revision.Oct 8 2025, 7:39 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 8 2025, 7:39 PM

kevans requested review of this revision.Oct 8 2025, 7:39 PM

Harbormaster completed remote builds in B67647: Diff 163789.Oct 8 2025, 7:39 PM

flo_purplekraken.com added a subscriber: flo_purplekraken.com.Oct 8 2025, 7:42 PM

markj accepted this revision.Oct 9 2025, 12:57 PM

This revision is now accepted and ready to land.Oct 9 2025, 12:57 PM

Closed by commit rG541a98d7e28a: compat: linux: use appropriate variables for copying out old timers (authored by kevans, committed by dim). · Explain WhyDec 28 2025, 10:04 PM

This revision was automatically updated to reflect the committed changes.

dim added a commit: rG541a98d7e28a: compat: linux: use appropriate variables for copying out old timers.

dim added a commit: rG7d0243317f3a: compat: linux: use appropriate variables for copying out old timers.Jan 2 2026, 8:52 PM

dim added a commit: rG0c5ac3e46e78: compat: linux: use appropriate variables for copying out old timers.

dim added a commit: rG958f2ab6d400: compat: linux: use appropriate variables for copying out old timers.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_timer.c

4 lines

Diff 163789

View Options

sys/compat/linux/linux_timer.c

compat: linux: use appropriate variables for copying out old timersClosedPublicActions