Page MenuHomeFreeBSD
Differential D52862

thunderbolt: Pink Sardine support
ClosedPublic
Actions

Authored by obiwac on Oct 2 2025, 3:50 PM.
Tags
None
Referenced Files
F170993176: D52862.id163354.diff
Tue, Sep 8, 1:49 AM
Unknown Object (File)
Mon, Sep 7, 12:02 PM
Unknown Object (File)
Mon, Sep 7, 10:14 AM
Unknown Object (File)
Mon, Sep 7, 8:30 AM
Unknown Object (File)
Sun, Sep 6, 3:16 AM
Unknown Object (File)
Sat, Sep 5, 3:11 PM
Unknown Object (File)
Sat, Sep 5, 2:37 PM
Unknown Object (File)
Fri, Sep 4, 11:46 PM
View All Files
Subscribers
seuros

Details

Reviewers
emaste
imp
jhb
mohammad_fbsdphab_thelightbird.com
Commits
rG7858a57baa2f: thunderbolt: Explicitly read NHI ISR0 register to clear it
Summary

Support Pink Sardine NHIs. The only practical change this requires is
clearing the ISR0 register.

Also add IDs for the Pink Sardine PCI-PCI bridge to tb_pcib.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67493
Build 64376: arc lint + arc unit

Event Timeline

obiwac requested review of this revision.Oct 2 2025, 3:50 PM
obiwac created this revision.
Harbormaster completed remote builds in B67493: Diff 163354.Oct 2 2025, 3:50 PM
obiwac added a parent revision: D52861: thunderbolt: Support generic USB4 NHIs.Oct 2 2025, 3:51 PM
obiwac added inline comments.
sys/dev/thunderbolt/nhi.c
1057

See comment in D49451 about specifying where this reference is from. Though maybe I should do a separate commit with this change to all existing references in the USB4 code.

obiwac mentioned this in D49451: USB4 Pink Sardine controller support.Oct 2 2025, 3:53 PM
emaste added inline comments.Oct 2 2025, 3:54 PM
sys/dev/thunderbolt/nhi.c
1057

Yeah, I'd just go ahead and make that change for any existing references first.

obiwac updated this revision to Diff 172660.Feb 25 2026, 9:24 AM

Rebase

Harbormaster completed remote builds in B70984: Diff 172660.Feb 25 2026, 9:24 AM
obiwac mentioned this in D52861: thunderbolt: Support generic USB4 NHIs.Mar 4 2026, 1:04 PM
obiwac mentioned this in D49452: USB4 host reset (& writing to router config space).Apr 24 2026, 2:57 PM
emaste added a subscriber: seuros.Wed, Aug 12, 5:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Aug 13, 5:51 AM
Closed by commit rG7858a57baa2f: thunderbolt: Explicitly read NHI ISR0 register to clear it (authored by obiwac). · Explain Why
This revision was automatically updated to reflect the committed changes.
obiwac added a commit: rG7858a57baa2f: thunderbolt: Explicitly read NHI ISR0 register to clear it.

Revision Contents
Changeset List

PathSize
sys/
dev/
thunderbolt/
14 lines
4 lines
2 lines
4 lines

Diff 163354

View Options

sys/dev/thunderbolt/nhi.c

Loading...
View Options

sys/dev/thunderbolt/router.c

Loading...
View Options

sys/dev/thunderbolt/tb_pcib.h

Loading...
View Options

sys/dev/thunderbolt/tb_pcib.c

Loading...