USB4 acknowledge hotplug events
Changes PlannedPublic
Actions

Authored by obiwac_gmail.com on Mar 22 2025, 1:56 AM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, May 23, 8:20 PM

	Unknown Object (File)
	Apr 7 2025, 10:55 AM

	Unknown Object (File)
	Apr 7 2025, 9:40 AM

	Unknown Object (File)
	Apr 7 2025, 9:40 AM

	Unknown Object (File)
	Apr 7 2025, 9:40 AM

	Unknown Object (File)
	Apr 7 2025, 9:40 AM

	Unknown Object (File)
	Apr 7 2025, 9:40 AM

	Unknown Object (File)
	Apr 6 2025, 4:16 PM

View All 20 Files

Subscribers

imp

Details

Reviewers

mohammad_fbsdphab_thelightbird.com
imp
jhb
emaste

Summary

When getting a hotplug event from the hardware, transmit a hotplug acknowledgment packet. This is needed even if we don't do anything with the hotplug events, as the hardware will continuously "spam" us with hotplug events otherwise.

Test Plan

Tested on AMD Pink Sardine controller (1022:1668/9), which is host interface version 1.0.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63049
Build 59933: arc lint + arc unit

Event Timeline

obiwac_gmail.com created this revision.Mar 22 2025, 1:56 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 22 2025, 1:56 AM

obiwac_gmail.com requested review of this revision.Mar 22 2025, 1:56 AM

Harbormaster completed remote builds in B63049: Diff 152528.Mar 22 2025, 1:56 AM

obiwac_gmail.com added a parent revision: D49450: USB4 base.Mar 22 2025, 1:56 AM

I want to factor out a notify function first.

obiwac_gmail.com added reviewers: imp, jhb, emaste.Mar 22 2025, 3:23 AM

I'll take a look once you're done with the planned changes you've flagged.

Revision Contents
Changeset List

Path

Size

sys/

dev/

thunderbolt/

router.c

83 lines

tbcfg_reg.h

6 lines

Diff 152528

View Options

sys/dev/thunderbolt/router.c