USB4 host reset (& writing to router config space)
Needs ReviewPublic
Actions

Authored by obiwac_gmail.com on Mar 22 2025, 1:45 AM.

Details

Reviewers

mohammad_fbsdphab_thelightbird.com
emaste
jhb
imp

Summary

Get host interface version (either 1.0 or 2.0) and reset accordingly.

This required support for writing to router config space.

Test Plan

Tested on AMD Pink Sardine controller (1022:1668/9), which is host interface version 1.0. It would be nice to try this out on version 2.0, but unfortunately I don't have the hardware to do this as it is fairly new.

This does require the D49451 patch to work on Pink Sardine.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63791
Build 60675: arc lint + arc unit

Event Timeline

obiwac_gmail.com created this revision.Mar 22 2025, 1:45 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 22 2025, 1:45 AM

obiwac_gmail.com requested review of this revision.Mar 22 2025, 1:45 AM

Harbormaster completed remote builds in B63047: Diff 152526.Mar 22 2025, 1:45 AM

obiwac_gmail.com added a parent revision: D49450: USB4 base.Mar 22 2025, 1:45 AM

obiwac_gmail.com added a child revision: D49453: USB4 initial work on suspend routine.Mar 22 2025, 1:50 AM

obiwac_gmail.com mentioned this in D49450: USB4 base.Mar 22 2025, 3:21 AM

obiwac_gmail.com added reviewers: emaste, jhb, imp.Mar 22 2025, 3:24 AM

imp added inline comments.Mar 25 2025, 3:19 AM

sys/dev/thunderbolt/nhi.c
298	Why not NHI_SLPR_WAIT_US? C_HARDCLOCK? Why?

obiwac_gmail.com added inline comments.Mar 25 2025, 3:25 PM

sys/dev/thunderbolt/nhi.c
298	`NHI_SLPR_WAIT_US` is for the time between us setting SLP and the router setting SLPR. This is the same number but a different value defined elsewhere in the spec. Including these constants in this patch is a mistake, they're not used. Will remove. As for `C_HARDCLOCK`, I don't know, I had copied this line from another driver assuming it was the same. Will learn about this.