Paths

Table of Contentst

Differential D52486

kern/vfs_vnops.c: generalize the lock primitive for file foffset
ClosedPublic
Actions

Authored by kib on Sep 11 2025, 10:10 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 20, 3:07 PM

	Unknown Object (File)
	Wed, May 20, 2:44 PM

	Unknown Object (File)
	Wed, May 20, 4:09 AM

	Unknown Object (File)
	Wed, May 20, 2:45 AM

	Unknown Object (File)
	Wed, May 20, 12:51 AM

	Unknown Object (File)
	Sun, May 17, 10:48 AM

	Unknown Object (File)
	Sun, May 17, 4:50 AM

	Unknown Object (File)
	Sun, May 17, 12:55 AM

View All 91 Files

Subscribers

Details

Reviewers

markj
jhb

Commits

rG0ee6f5efdfc6: kern/vfs_vnops.c: generalize the lock primitive for file foffset
rG94a0f9f63e16: kern/vfs_vnops.c: generalize the lock primitive for file foffset

Summary

Generalize foffset_lock/unlock() by splitting the locking info
file_v_lock/unlock() (LP64 case) or file_v_lock/unlock_mtxp() for ILP32
(using mutex pool) and then taking the action to read the offset.

sys/file.h: rename struct file f_vnread_flags member into generic f_vflags

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Sep 11 2025, 10:10 AM

Herald added subscribers: olce, imp. · View Herald TranscriptSep 11 2025, 10:10 AM

kib requested review of this revision.Sep 11 2025, 10:10 AM

kib added a parent revision: D52487: fcntl(F_SETFL): only allow one thread to perform F_SETFL.Sep 11 2025, 10:13 AM

kib added inline comments.Sep 11 2025, 10:20 AM

sys/kern/vfs_vnops.c
871	Note that f_offset is no longer read under the sleepq lock in this case, but it does not matter.

markj added inline comments.Sep 11 2025, 1:50 PM

sys/kern/vfs_vnops.c
818	Should this be `state \| lock_bit`?

kib marked an inline comment as done.Sep 11 2025, 1:54 PM

kib added inline comments.

sys/kern/vfs_vnops.c
810	There too.

Fix CAS.

markj added inline comments.Sep 15 2025, 6:57 PM

sys/kern/vfs_vnops.c
804
813	and below
854	Why not use `flagsp` here?

Remove unneeded volatile qualifier for var accessed as atomic.
Systematically use flagsp.

markj accepted this revision.Sep 15 2025, 7:33 PM

This revision is now accepted and ready to land.Sep 15 2025, 7:33 PM

Closed by commit rG94a0f9f63e16: kern/vfs_vnops.c: generalize the lock primitive for file foffset (authored by kib). · Explain WhySep 19 2025, 2:20 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG94a0f9f63e16: kern/vfs_vnops.c: generalize the lock primitive for file foffset.

cperciva added a reverting change: rG1f2a65222b88: Revert "kern/vfs_vnops.c: generalize the lock primitive for file foffset".Sep 19 2025, 7:23 PM

kib added a commit: rG0ee6f5efdfc6: kern/vfs_vnops.c: generalize the lock primitive for file foffset.Sep 20 2025, 7:35 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

162 lines

sys/

6 lines

Diff 161902

sys/kern/vfs_vnops.c

Loading...

sys/sys/file.h

Loading...