fcntl(F_SETFL): only allow one thread to perform F_SETFL
ClosedPublic
Actions

Authored by kib on Sep 11 2025, 10:12 AM.

Details

Reviewers

jhb
markj

Commits

rG7bf3b6d8e426: fcntl(F_SETFL): only allow one thread to perform F_SETFL
rG11870bb24801: fcntl(F_SETFL): only allow one thread to perform F_SETFL
rG4c3a868d13c0: fcntl(F_SETFL): only allow one thread to perform F_SETFL
rG40a42785dbba: fcntl(F_SETFL): only allow one thread to perform F_SETFL

Summary

Use f_vflags file locking for this.
Allowing more than one thread handling F_SETFL might cause de-sync
between real driver state and flags.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sep 11 2025, 10:12 AM

Herald added subscribers: olce, imp. · View Herald TranscriptSep 11 2025, 10:12 AM

kib requested review of this revision.Sep 11 2025, 10:12 AM

kib added a child revision: D52486: kern/vfs_vnops.c: generalize the lock primitive for file foffset.

markj accepted this revision.Sep 15 2025, 6:44 PM

This revision is now accepted and ready to land.Sep 15 2025, 6:44 PM

Closed by commit rG40a42785dbba: fcntl(F_SETFL): only allow one thread to perform F_SETFL (authored by kib). · Explain WhySep 19 2025, 2:20 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG40a42785dbba: fcntl(F_SETFL): only allow one thread to perform F_SETFL.

cperciva added a reverting change: rG8f268240ee60: Revert "fcntl(F_SETFL): only allow one thread to perform F_SETFL".Sep 19 2025, 7:23 PM

kib added a commit: rG4c3a868d13c0: fcntl(F_SETFL): only allow one thread to perform F_SETFL.Sep 20 2025, 7:35 PM

jhb added a commit: rG11870bb24801: fcntl(F_SETFL): only allow one thread to perform F_SETFL.Dec 18 2025, 6:23 PM

jhb added a commit: rG7bf3b6d8e426: fcntl(F_SETFL): only allow one thread to perform F_SETFL.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_descrip.c

3 lines

vfs_vnops.c

36 lines

sys/

file.h

4 lines

Diff 162417

View Options

sys/kern/kern_descrip.c

View Options

sys/kern/vfs_vnops.c

View Options

fcntl(F_SETFL): only allow one thread to perform F_SETFLClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 162417

sys/kern/kern_descrip.c

sys/kern/vfs_vnops.c

sys/sys/file.h

fcntl(F_SETFL): only allow one thread to perform F_SETFL
ClosedPublic
Actions

Revision Contents
Changeset List