tcp: store flowid info in syncache
Needs ReviewPublic
Actions

Authored by glebius on Thu, Aug 7, 3:22 PM.

Details

Reviewers

None

Group Reviewers

Summary

This corrects two problems. First, retransmissions by syncache would use
correct flowid, same as synchronous responds. Second, this disables
inherting flowid for outgoing connections. The problem with outgoing
connections is that our very first SYN would go out with a different
flowid than the rest of the packets of the connection.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66063
Build 62946: arc lint + arc unit

Event Timeline

glebius created this revision.Thu, Aug 7, 3:22 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptThu, Aug 7, 3:22 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Thu, Aug 7, 3:22 PM

Harbormaster completed remote builds in B66063: Diff 159968.Thu, Aug 7, 3:22 PM

It looks like the syncache changes just ensure that you are sending syncache driven retransmissions with the same flowid than the original one, right?
I think that part of this review is without any discussion. Why not get that in as a separate commit. That allows us to focus on the problem of the client side...