Page MenuHomeFreeBSD
Differential D51792

tcp: store flowid info in syncache
ClosedPublic
Actions

Authored by glebius on Aug 7 2025, 3:22 PM.
Tags
None
Referenced Files
F139445578: D51792.id159968.diff
Fri, Dec 12, 4:26 AM
Unknown Object (File)
Sat, Nov 29, 8:07 PM
Unknown Object (File)
Fri, Nov 28, 12:03 AM
Unknown Object (File)
Sat, Nov 22, 7:53 PM
Unknown Object (File)
Sat, Nov 22, 7:52 PM
Unknown Object (File)
Sat, Nov 22, 7:52 PM
Unknown Object (File)
Sat, Nov 22, 7:48 PM
Unknown Object (File)
Nov 5 2025, 4:41 AM
View All 32 Files
Subscribers
imp
melifaro
p.mousavizadeh_protonmail.com
tuexen

Details

Reviewers
gallatin
tuexen
Group Reviewers
transport
Commits
rG73fe85e486d2: tcp: store flowid info in syncache
Summary

Now retransmissions by syncache would use correct flowid, same as
synchronous responds.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68811
Build 65694: arc lint + arc unit

Event Timeline

glebius created this revision.Aug 7 2025, 3:22 PM
Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptAug 7 2025, 3:22 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
glebius requested review of this revision.Aug 7 2025, 3:22 PM
Harbormaster completed remote builds in B66063: Diff 159968.Aug 7 2025, 3:22 PM
tuexen added a subscriber: tuexen.Aug 11 2025, 10:06 PM

It looks like the syncache changes just ensure that you are sending syncache driven retransmissions with the same flowid than the original one, right?
I think that part of this review is without any discussion. Why not get that in as a separate commit. That allows us to focus on the problem of the client side...

p.mousavizadeh_protonmail.com added a subscriber: p.mousavizadeh_protonmail.com.Sep 18 2025, 3:26 PM
glebius updated this revision to Diff 166977.Sat, Nov 22, 6:52 PM
  • Rebase on main.
  • Separate tcp_input() change into its own commit.
Harbormaster completed remote builds in B68811: Diff 166977.Sat, Nov 22, 6:52 PM
glebius added a child revision: D53886: tcp: don't set flowid in tcp_input().Sat, Nov 22, 6:53 PM
glebius edited the summary of this revision. (Show Details)Sat, Nov 22, 6:53 PM
glebius added a reviewer: gallatin.
tuexen accepted this revision.Sun, Nov 23, 8:51 AM
This revision is now accepted and ready to land.Sun, Nov 23, 8:51 AM
gallatin accepted this revision.Mon, Nov 24, 12:53 AM
tuexen added inline comments.Mon, Nov 24, 9:52 PM
sys/netinet/tcp_syncache.h
78

Isn't a uint8_t good enough for sc_flowtype? Wouldn't moving a uint8_t sc_flowtype before sc_flags save 4 bytes?

Closed by commit rG73fe85e486d2: tcp: store flowid info in syncache (authored by glebius). · Explain WhyWed, Dec 3, 11:20 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG73fe85e486d2: tcp: store flowid info in syncache.

Revision Contents
Changeset List

PathSize
sys/
netinet/
2 lines
8 lines
101 lines

Diff 166977

View Options

sys/netinet/tcp_input.c

Loading...
View Options

sys/netinet/tcp_syncache.h

Loading...
View Options

sys/netinet/tcp_syncache.c

Loading...