Differential D51552

vmm/amd64: port illumos cpuid control
Needs ReviewPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Sat, Jul 26, 11:17 AM.

Details

Reviewers

None

Group Reviewers

bhyve

Summary

This is a faithful port of two bhyve improvements coming from illumos:

14485 bhyve needs better cpuid control https://www.illumos.org/issues/14485 This adds vmm kernel support for overriding the CPUID information for a guest.
16223 bhyve returns bogus cpuid 8000_001D leaf https://www.illumos.org/issues/16223 This fixes an issue in 14485 discovered on AMD CPUs.

This does not include the bhyve tests added with illumos#14485 since
FreeBSD lacks the bhyve test suite. This does also not contain any
libvmmapi/bhyve userspace code to make this feature actually useful.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65751
Build 62634: arc lint + arc unit

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Sat, Jul 26, 11:17 AM

Herald added a reviewer: bhyve. · View Herald TranscriptSat, Jul 26, 11:17 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

rosenfeld_grumpf.hope-2000.org requested review of this revision.Sat, Jul 26, 11:17 AM

Harbormaster completed remote builds in B65751: Diff 159179.Sat, Jul 26, 11:17 AM

rosenfeld_grumpf.hope-2000.org added a parent revision: D51551: bhyve: want walk_config_nodes.Sat, Jul 26, 11:18 AM

rosenfeld_grumpf.hope-2000.org added a child revision: D51553: vmm/amd64: VM_SET_CPUID ioctl should refuse zero-entry non-legacy cpuid cfg.Sat, Jul 26, 11:20 AM

corvink added a subscriber: corvink.Mon, Jul 28, 9:37 AM

corvink added inline comments.

sys/amd64/include/vmm.h
808
826
sys/amd64/vmm/vmm_cpuid.c
28	This shouldn't be required anymore.
572	This could be split into a separate commit to make it easier to review and merge earlier if you like to.
sys/amd64/vmm/vmm_dev_machdep.c
504–521	That's checked by vm_set_cpuid too. I would prefer checking this stuff once.