lib: Only build libcom_err with Heimdal
ClosedPublic
Actions

Authored by cy on Jun 12 2025, 2:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 14, 7:12 AM

	Unknown Object (File)
	Tue, Jul 8, 10:06 AM

	Unknown Object (File)
	Tue, Jul 8, 6:46 AM

	Unknown Object (File)
	Tue, Jun 24, 6:50 PM

	Unknown Object (File)
	Fri, Jun 20, 11:10 PM

	Unknown Object (File)
	Fri, Jun 20, 4:23 PM

	Unknown Object (File)
	Jun 18 2025, 4:04 PM

	Unknown Object (File)
	Jun 16 2025, 4:28 AM

View All 13 Files

Subscribers

None

Details

Reviewers

imp
jhb
jrm
emaste
markj
fuz
sjg
bapt

Commits

rG0acf1dd7929b: lib: Only build libcom_err with Heimdal

Summary

MIT KRB5 provides its own libcom_err.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cy requested review of this revision.Jun 12 2025, 2:52 PM

cy created this revision.

I guess _prebuild_libs in Makefile.inc1 doesn't need to be updated--MK_KERBEROS always refers to Heimdal kerberos?

This revision is now accepted and ready to land.Jun 12 2025, 2:59 PM

In D50809#1159678, @markj wrote:

I guess _prebuild_libs in Makefile.inc1 doesn't need to be updated--MK_KERBEROS always refers to Heimdal kerberos?

That's in a different revision. It didn't make sense to pick apart the Makefile.inc1 patch to separate this out. There is a separate revision for hooking MIT KRB5 into the build which includes all the Makefile.inc1 patches.

emaste accepted this revision.Jun 12 2025, 5:37 PM

Closed by commit rG0acf1dd7929b: lib: Only build libcom_err with Heimdal (authored by cy). · Explain WhyJun 16 2025, 2:53 AM

This revision was automatically updated to reflect the committed changes.

cy added a commit: rG0acf1dd7929b: lib: Only build libcom_err with Heimdal.

Revision Contents
Changeset List

Path

Size

lib/

Makefile

2 lines

Diff 157079

View Options

lib: Only build libcom_err with HeimdalClosedPublicActions