ifconfig: reject netmask and broadcast for inet6
ClosedPublic
Actions

Authored by ivy on Mon, May 19, 4:14 AM.

Details

Reviewers

des
kevans
ngie
zlei
cy

Group Reviewers

network
tests

Commits

rGcf624ffa812c: ifconfig: reject netmask and broadcast for inet6
rG59ee9260e6bb: ifconfig: reject netmask and broadcast for inet6

Summary

we don't support setting netmask or broadcast address for INET6
addresses, and trying to do crashes ifconfig. handle this the
same way as af_link, by rejecting attempts to configure these
parameters.

PR: 286910
Reported by: Hayzam Sherif <hayzam@alchemilla.io>
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Mon, May 19, 4:14 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, May 19, 4:14 AM

ivy requested review of this revision.Mon, May 19, 4:14 AM

Harbormaster completed remote builds in B64283: Diff 155677.Mon, May 19, 4:15 AM

des added inline comments.Mon, May 19, 4:58 AM

sbin/ifconfig/tests/Makefile
1	I know this looks weird but it's a genuine test script for `ifconfig` from NetBSD, please don't remove it.

keep the oddly-named netbsd test

Herald added a reviewer: ngie. · View Herald TranscriptMon, May 19, 5:03 AM

Harbormaster completed remote builds in B64284: Diff 155679.Mon, May 19, 5:03 AM

des accepted this revision.Mon, May 19, 5:03 AM

This revision is now accepted and ready to land.Mon, May 19, 5:03 AM

ivy marked an inline comment as done.Mon, May 19, 5:28 AM

Generally looks good to me.

sbin/ifconfig/af_inet6.c
432	IPv6 does not have terminology such as `netmask` or `broadcast`. I'm not a native speaker, but that `IPv6 netmask / broadcast` sounds confusing to me.
sbin/ifconfig/tests/inet6.sh
39	IPv6 does not have terminology such as netmask or broadcast Do not forget to update the test case as well.

ivy added inline comments.Mon, May 19, 10:09 AM

sbin/ifconfig/af_inet6.c
432	would you be happier with something like "can't set netmask or broadcast for inet6"?

zlei added inline comments.Tue, May 20, 9:10 AM

sbin/ifconfig/af_inet6.c
432	would you be happier with something like "can't set netmask or broadcast for inet6"? Or it is better to show the reason, say "Invalid option netmask / broadcast" ?