Paths

Table of Contentst

Differential D49357

netinet6: Remove set but not used global variable in6_maxmtu
ClosedPublic
Actions

Authored by zlei on Mar 14 2025, 11:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 8, 10:20 AM

	Unknown Object (File)
	Sat, Feb 7, 9:09 PM

	Unknown Object (File)
	Sat, Feb 7, 8:46 PM

	Unknown Object (File)
	Sun, Feb 1, 9:13 PM

	Unknown Object (File)
	Sat, Jan 31, 8:07 AM

	Unknown Object (File)
	Fri, Jan 30, 9:01 PM

	Unknown Object (File)
	Fri, Jan 30, 7:35 PM

	Unknown Object (File)
	Fri, Jan 30, 3:56 AM

View All 86 Files

Subscribers

Details

Reviewers

glebius
melifaro

Group Reviewers

network
transport

Commits

rGf5195b1a63df: netinet6: Remove a set but not used global variable in6_maxmtu
rGe64fe5ad3a23: netinet6: Remove a set but not used global variable in6_maxmtu

Summary

This was introduced by the KAME project, but it appears to serve no purpose.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Mar 14 2025, 11:53 AM

Herald added subscribers: ae, imp. · View Herald TranscriptMar 14 2025, 11:53 AM

zlei requested review of this revision.Mar 14 2025, 11:53 AM

zlei mentioned this in D49358: ifnet: Initialize address family dependent data region earlier.Mar 14 2025, 12:06 PM

glebius added inline comments.Mar 14 2025, 4:52 PM

sys/netinet6/nd6_rtr.c
555–560	This can be simplified and avoids extra memory write if MTU didn't change. if (mtu <= maxmtu && ndi->linkmtu != mtu); ndi->linkmtu = mtu; rt_updatemtu(ifp); } else {

zlei added inline comments.Apr 10 2025, 3:00 AM

sys/netinet6/nd6_rtr.c
555–560	This can be simplified and avoids extra memory write if MTU didn't change. Emm, then the else block nd6log((LOG_INFO, "%s: bogus mtu=%lu sent from % may lost reporting when `mtu > maxmtu && ndi->linkmtu == mtu` .

zlei added inline comments.Apr 10 2025, 3:20 AM

sys/netinet6/nd6_rtr.c
555–560	may lost reporting when mtu > maxmtu && ndi->linkmtu == mtu The above is wrong. May falsely report bogus mtu when `ndi->linkmtu == mtu`.

Removed local var change.

glebius accepted this revision as: glebius.Apr 10 2025, 3:29 PM

This revision is now accepted and ready to land.Apr 10 2025, 3:29 PM

Closed by commit rGe64fe5ad3a23: netinet6: Remove a set but not used global variable in6_maxmtu (authored by zlei). · Explain WhyMay 21 2025, 10:13 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGe64fe5ad3a23: netinet6: Remove a set but not used global variable in6_maxmtu.

zlei added a commit: rGf5195b1a63df: netinet6: Remove a set but not used global variable in6_maxmtu.Jul 7 2025, 10:08 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

25 lines

6 lines

4 lines

4 lines

8 lines

Diff 153432

sys/netinet6/in6.c

Loading...

sys/netinet6/in6_ifattach.c

Loading...

sys/netinet6/in6_var.h

Loading...

sys/netinet6/nd6.c

Loading...

sys/netinet6/nd6_rtr.c

Loading...