MAC/do: Convert internal TAILQs to STAILQs
ClosedPublic
Actions

Authored by olce on Nov 15 2024, 5:08 PM.

Details

Reviewers

bapt
emaste

Commits

rGc7fc71c6af07: MAC/do: Convert internal TAILQs to STAILQs

Summary

This revision is part of a series. Click on the Stack tab below to see the context.
This series has also been squeezed into D47633 to provide an overall view.

Commit message:
We only browse these forward and never need to remove arbitrary elements
from them.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60615
Build 57499: arc lint + arc unit

Event Timeline

olce created this revision.Nov 15 2024, 5:08 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 15 2024, 5:08 PM

olce requested review of this revision.Nov 15 2024, 5:08 PM

Harbormaster completed remote builds in B60615: Diff 146557.Nov 15 2024, 5:08 PM

olce mentioned this in D47633: MAC/do 2.0.Nov 15 2024, 10:43 PM

olce edited the summary of this revision. (Show Details)

olce added a parent revision: D47623: MAC/do: parse_rules(): Tolerate blanks around tokens.Nov 15 2024, 10:47 PM

olce added a reviewer: bapt.Nov 15 2024, 10:50 PM

olce added subscribers: lwhsu, emaste.Nov 15 2024, 10:52 PM

olce added a subscriber: jlduran.Nov 18 2024, 8:51 AM

It's worth expanding the commit message - even if there's no functional change intended we should say why we're bothering with the change. Presumably it is because we only ever iterate over these in the forward direction so we can avoid the additional overhead.

But, LGTM.

In D47624#1086651, @emaste wrote:

It's worth expanding the commit message - even if there's no functional change intended we should say why we're bothering with the change. Presumably it is because we only ever iterate over these in the forward direction so we can avoid the additional overhead.

But, LGTM.

Done.

bapt accepted this revision.Nov 21 2024, 9:23 PM

This revision is now accepted and ready to land.Nov 21 2024, 9:23 PM

emaste accepted this revision.Nov 21 2024, 9:37 PM

olce added a child revision: D47845: MAC/do: Apply a rule on real UID/GID instead of effective ones.Nov 29 2024, 8:37 PM

Closed by commit rGc7fc71c6af07: MAC/do: Convert internal TAILQs to STAILQs (authored by olce). · Explain WhyDec 16 2024, 2:47 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGc7fc71c6af07: MAC/do: Convert internal TAILQs to STAILQs.