Page MenuHomeFreeBSD

unix: Add support for atomically setting the socket mode
ClosedPublic

Authored by markj on Oct 31 2024, 6:30 PM.
Tags
None
Referenced Files
F163372632: D47361.diff
Wed, Jul 22, 3:03 PM
F163347456: D47361.id145818.diff
Wed, Jul 22, 9:15 AM
F163328083: D47361.id145772.diff
Wed, Jul 22, 4:01 AM
Unknown Object (File)
Tue, Jul 21, 10:25 PM
Unknown Object (File)
Tue, Jul 21, 3:36 AM
Unknown Object (File)
Mon, Jul 20, 3:24 AM
Unknown Object (File)
Sat, Jul 18, 11:14 AM
Unknown Object (File)
Sat, Jul 11, 11:15 PM
Subscribers

Details

Summary

With this patch, it is possible to call fchmod() on a unix socket prior
to binding it to the filesystem namespace, so that the mode is set
atomically. Without this, one has to call chmod() after bind(), leaving
a window where threads can connect to the socket with the default mode.
After bind(), fchmod() reverts to failing with EINVAL.

I believe this is compatible with Linux.

I did not modify the behaviour of fstat(), i.e., it continues to return
the mode as set by soo_stat().

PR: 282393

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60294
Build 57178: arc lint + arc unit

Event Timeline

markj requested review of this revision.Oct 31 2024, 6:30 PM

sys/_types.h is sufficient.

Update man pages, add some tests.

markj added reviewers: glebius, kib.
This revision is now accepted and ready to land.Nov 1 2024, 11:37 AM