Page MenuHomeFreeBSD
Differential D46989

sys: Add an SMCCC Random Number Generator driver
ClosedPublic
Actions

Authored by andrew on Oct 7 2024, 4:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 15, 3:20 AM
Unknown Object (File)
Mon, Dec 15, 1:40 AM
Unknown Object (File)
Fri, Dec 5, 4:20 AM
Unknown Object (File)
Mon, Nov 24, 9:52 AM
Unknown Object (File)
Sat, Nov 22, 1:52 PM
Unknown Object (File)
Fri, Nov 21, 8:34 PM
Unknown Object (File)
Nov 11 2025, 10:39 AM
Unknown Object (File)
Nov 9 2025, 2:38 AM
View All Files
Subscribers
cem
emaste
imp
markm
obrien

Details

Reviewers
markm
cem
Group Reviewers
arm64
csprng
Commits
rGb2f8b2dc8736: sys: Add an SMCCC Random Number Generator driver
Summary

The Arm True Random Number Generator Firmware Interface provides a way
to query the SMCCC firmware for up to 192 bits of entropy. Use it to
provide another source of randomness to the kernel.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59817
Build 56702: arc lint + arc unit

Event Timeline

andrew created this revision.Oct 7 2024, 4:54 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptOct 7 2024, 4:54 PM
andrew requested review of this revision.Oct 7 2024, 4:54 PM
Herald added a subscriber: obrien. · View Herald TranscriptOct 7 2024, 4:54 PM
andrew added a parent revision: D46988: dev/psci: Make SMCCC into a real driver.Oct 7 2024, 4:54 PM
Harbormaster completed remote builds in B59817: Diff 144422.Oct 7 2024, 4:54 PM
andrew added a reviewer: csprng.Oct 7 2024, 4:55 PM
andrew updated this revision to Diff 144423.Oct 7 2024, 4:56 PM

Remove an old TODO comment

Harbormaster completed remote builds in B59818: Diff 144423.Oct 7 2024, 4:56 PM
markm accepted this revision.Oct 7 2024, 5:15 PM
markm added a subscriber: markm.

Looks OK to me.

This revision is now accepted and ready to land.Oct 7 2024, 5:15 PM
cem added a subscriber: cem.Oct 7 2024, 6:10 PM
cem added inline comments.
sys/dev/psci/smccc_trng.c
114

If this source supports 192 bits per request, why truncate to 64?

119

Earlier we use arm_smccc_invoke. What’s the difference?

andrew updated this revision to Diff 144518.Oct 9 2024, 9:22 AM
  • Check for SMCCC 1.1
  • Remove an unused variable
  • Use arm_smccc_invoke
This revision now requires review to proceed.Oct 9 2024, 9:22 AM
Harbormaster completed remote builds in B59858: Diff 144518.Oct 9 2024, 9:22 AM
andrew added inline comments.Oct 9 2024, 11:37 AM
sys/dev/psci/smccc_trng.c
114

It's simpler to do so and we only ever ask for 64 bits in random_sources_feed

cem accepted this revision.Oct 9 2024, 5:26 PM

Thanks.

This revision is now accepted and ready to land.Oct 9 2024, 5:26 PM
Closed by commit rGb2f8b2dc8736: sys: Add an SMCCC Random Number Generator driver (authored by andrew). · Explain WhyOct 15 2024, 5:30 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGb2f8b2dc8736: sys: Add an SMCCC Random Number Generator driver.

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
dev/
psci/
141 lines
random/
1 line
sys/
1 line

Diff 144422

View Options

sys/conf/files.arm64

Loading...
View Options

sys/dev/psci/smccc_trng.c

Loading...
View Options

sys/dev/random/random_harvestq.c

Loading...
View Options

sys/sys/random.h

Loading...