Page MenuHomeFreeBSD
Differential D46717

diff: support -qq to output absolutely nothing
Needs ReviewPublic
Actions

Authored by allanjude on Sep 20 2024, 3:31 PM.
Tags
None
Referenced Files
F175398216: D46717.id143542.diff
Sat, Oct 10, 1:59 PM
F175311817: D46717.id.diff
Fri, Oct 9, 9:14 PM
F175286836: D46717.id143542.diff
Fri, Oct 9, 4:52 PM
F175286786: D46717.id188889.diff
Fri, Oct 9, 4:52 PM
Unknown Object (File)
Fri, Oct 9, 4:07 PM
Unknown Object (File)
Fri, Oct 9, 3:52 PM
Unknown Object (File)
Fri, Oct 9, 10:11 AM
Unknown Object (File)
Thu, Oct 8, 11:12 PM
View All Files
Subscribers
imp
michaelo
ziaee

Details

Reviewers
markj
gordon
kevans
des
bapt
Group Reviewers
Klara
Summary

diff: support -qq to output absolutely nothing

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59540
Build 56427: arc lint + arc unit

Event Timeline

allanjude created this revision.Sep 20 2024, 3:31 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 20 2024, 3:31 PM
allanjude requested review of this revision.Sep 20 2024, 3:31 PM
Harbormaster completed remote builds in B59540: Diff 143542.Sep 20 2024, 3:31 PM
allanjude added a comment.Sep 20 2024, 3:31 PM

still a WIP

markj added inline comments.Sep 21 2024, 1:24 PM
usr.bin/diff/diff.c
279

This way, if one writes -qqq, it'll flip back to D_BRIEF. I guess that's not intentional?

usr.bin/diff/diff.h
51
allanjude updated this revision to Diff 188889.Tue, Oct 6, 6:11 PM

Address markj's feedback

Harbormaster completed remote builds in B77775: Diff 188889.Tue, Oct 6, 6:11 PM
allanjude added reviewers: kevans, Klara.Tue, Oct 6, 6:11 PM
allanjude marked 2 inline comments as done.
allanjude mentioned this in D46716: periodic 100.chksetuid: supress output if diff is purely whitespace.Tue, Oct 6, 6:17 PM
michaelo added a subscriber: michaelo.Tue, Oct 6, 6:19 PM

PLease MFC this, it is trivial.

allanjude edited the summary of this revision. (Show Details)Tue, Oct 6, 6:43 PM
allanjude edited the summary of this revision. (Show Details)
allanjude added reviewers: des, bapt.Thu, Oct 8, 7:27 PM
des added a comment.Thu, Oct 8, 8:57 PM

What is the point of this? cmp -s will do the same job faster.

usr.bin/diff/diff.c
278

typo

bapt added a comment.Fri, Oct 9, 6:53 AM

I don't understand the point of it either, is it for compatibility? but on the technical side this is ok with me.

ziaee added a subscriber: ziaee.Sat, Oct 10, 1:25 PM

If you're going to do this, can you update the doc? I'm partial to what we did in pkg.8:

Specify twice
.Pq Fl vv
to also show nothing

But, having multiple ways to do the same thing is the enemy of coherency. Also diff has an intense amount of flags already.

Revision Contents
Changeset List

PathSize
usr.bin/
diff/
1 line
5 lines
7 lines

Diff 143542

View Options

usr.bin/diff/diff.h

Loading...
View Options

usr.bin/diff/diff.c

Loading...
View Options

usr.bin/diff/diffreg.c

Loading...