pf tests: improved test for CVE-2019-5598
ClosedPublic
Actions

Authored by kp on Sat, Sep 7, 9:33 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 18, 6:27 AM

	Unknown Object (File)
	Tue, Sep 17, 6:09 PM

	Unknown Object (File)
	Tue, Sep 17, 6:31 AM

	Unknown Object (File)
	Tue, Sep 17, 5:06 AM

	Unknown Object (File)
	Fri, Sep 13, 4:00 PM

	Unknown Object (File)
	Fri, Sep 13, 4:00 PM

	Unknown Object (File)
	Fri, Sep 13, 4:00 PM

	Unknown Object (File)
	Thu, Sep 12, 2:34 AM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rGb27d3f71c2ad: pf tests: improved test for CVE-2019-5598

Summary

Ensure that we verify that the inner and outer IP address matches for ICMP error
messages. This is a more detailed test for CVE-2019-5598, which was fixed back
in 2019.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59361
Build 56248: arc lint + arc unit

Event Timeline

kp created this revision.Sat, Sep 7, 9:33 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSat, Sep 7, 9:33 AM

kp requested review of this revision.Sat, Sep 7, 9:33 AM

Harbormaster completed remote builds in B59361: Diff 143069.Sat, Sep 7, 9:33 AM

kp added a parent revision: D46572: opencrypto: assert that mbufs are writable.Sat, Sep 7, 9:33 AM

kp added a child revision: D46574: pf: fix debug printf.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 11, 11:18 AM

Closed by commit rGb27d3f71c2ad: pf tests: improved test for CVE-2019-5598 (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGb27d3f71c2ad: pf tests: improved test for CVE-2019-5598.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

Makefile

1 line

icmp.py

126 lines

Diff 143069

View Options

tests/sys/netpfil/pf/Makefile