Page MenuHomeFreeBSD
Differential D46267

faccessat(2): Honor AT_SYMLINK_NOFOLLOW
ClosedPublic
Actions

Authored by fernape on Aug 10 2024, 11:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 18, 10:43 AM
Unknown Object (File)
Wed, Sep 16, 4:08 AM
Unknown Object (File)
Sat, Sep 12, 7:54 AM
Unknown Object (File)
Fri, Sep 11, 3:58 PM
Unknown Object (File)
Fri, Sep 11, 6:15 AM
Unknown Object (File)
Thu, Sep 10, 11:25 PM
Unknown Object (File)
Thu, Sep 10, 5:18 PM
Unknown Object (File)
Wed, Sep 9, 12:10 PM
View All Files
Subscribers
imp
olce

Details

Reviewers
kib
Commits
rGddbbc129ae0f: faccessat(2): Honor AT_SYMLINK_NOFOLLOW
rG5ab6ed93cd36: faccessat(2): Honor AT_SYMLINK_NOFOLLOW
Summary

Make the system call honor AT_SYMLINK_NOFOLLOW.

Also enable this from linux_faccessat2 where the issue arised the first time.
Update manual pages accordingly.

PR: 275295

Test Plan

Apply the patch and use a simple program to test the system call.
One such program can be found here.

AFAICT, this change is POSIX-compliant.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58985
Build 55872: arc lint + arc unit

Event Timeline

fernape created this revision.Aug 10 2024, 11:45 AM
Herald added subscribers: olce, imp. · View Herald TranscriptAug 10 2024, 11:45 AM
fernape requested review of this revision.Aug 10 2024, 11:45 AM
Harbormaster completed remote builds in B58982: Diff 141976.Aug 10 2024, 11:46 AM
fernape edited the summary of this revision. (Show Details)Aug 10 2024, 11:47 AM
fernape edited the test plan for this revision. (Show Details)
fernape added a reviewer: kib.
kib added a comment.Aug 10 2024, 10:36 PM

Do not forget to bump the man page's dates.

sys/compat/linux/linux_file.c
639–640

This line should be wrapped.

sys/kern/vfs_syscalls.c
2155–2156

The line should be wrapped. I do not see a need to add {} around the body.

fernape updated this revision to Diff 141987.Aug 11 2024, 10:34 AM
  • Address kib's feedback.
Harbormaster completed remote builds in B58984: Diff 141987.Aug 11 2024, 10:34 AM
fernape marked 2 inline comments as done.Aug 11 2024, 10:34 AM
In D46267#1055079, @kib wrote:

Do not forget to bump the man page's dates.

Yes, I will bump .Dd at commit time.

kib added inline comments.Aug 11 2024, 10:50 AM
sys/compat/linux/linux_file.c
640

Indent for the continuation line should be +4 spaces

sys/kern/vfs_syscalls.c
46

Stray chunk

2156

Again, indent should be +4 spaces

fernape updated this revision to Diff 141988.Aug 11 2024, 12:13 PM
  • Use +4 spaces for indentation.
Harbormaster completed remote builds in B58985: Diff 141988.Aug 11 2024, 12:13 PM
fernape updated this revision to Diff 141989.Aug 11 2024, 12:14 PM
fernape marked 2 inline comments as done.
  • Remove stray change.
Harbormaster completed remote builds in B58986: Diff 141989.Aug 11 2024, 12:14 PM
fernape marked an inline comment as done.Aug 11 2024, 12:14 PM
kib accepted this revision.Aug 11 2024, 12:19 PM
This revision is now accepted and ready to land.Aug 11 2024, 12:19 PM
Closed by commit rG5ab6ed93cd36: faccessat(2): Honor AT_SYMLINK_NOFOLLOW (authored by fernape). · Explain WhyAug 11 2024, 3:54 PM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rG5ab6ed93cd36: faccessat(2): Honor AT_SYMLINK_NOFOLLOW.
emaste added a commit: rGddbbc129ae0f: faccessat(2): Honor AT_SYMLINK_NOFOLLOW.Sep 26 2024, 2:47 PM

Revision Contents
Changeset List

PathSize
bin/
ln/
1 line
lib/
libsys/
4 lines
sys/
compat/
linux/
6 lines
kern/
8 lines

Diff 141988

View Options

bin/ln/symlink.7

Loading...
View Options

lib/libsys/access.2

Loading...
View Options

sys/compat/linux/linux_file.c

Loading...
View Options

sys/kern/vfs_syscalls.c

Loading...