Page MenuHomeFreeBSD
Differential D44378

syscall.master: fix aio_suspend signature
ClosedPublic
Actions

Authored by brooks on Mar 15 2024, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 30, 8:25 PM
Unknown Object (File)
Sat, Sep 12, 2:27 PM
Unknown Object (File)
Fri, Sep 11, 6:45 PM
Unknown Object (File)
Tue, Sep 8, 3:12 AM
Unknown Object (File)
Sun, Sep 6, 10:26 AM
Unknown Object (File)
Sun, Sep 6, 6:11 AM
Unknown Object (File)
Sat, Sep 5, 3:40 PM
Unknown Object (File)
Sat, Sep 5, 10:48 AM
View All Files
Subscribers
imp
olce

Details

Reviewers
kib
Commits
rGd8d4ed26c92d: syscall.master: fix aio_suspend signature
Summary

It takes a const struct iovec *iovp.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56632
Build 53520: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 15 2024, 10:45 PM
Herald added subscribers: olce, imp. · View Herald TranscriptMar 15 2024, 10:45 PM
brooks requested review of this revision.Mar 15 2024, 10:45 PM
Harbormaster completed remote builds in B56632: Diff 135802.Mar 15 2024, 10:45 PM
brooks added a parent revision: D44377: syscalls.master: fix readv and writev iovp decl.Mar 15 2024, 10:45 PM
brooks added a child revision: D44379: syscalls.master: align with sigfastblock declaration.
kib accepted this revision.Mar 16 2024, 1:28 AM

Ok, but this change by itself does not change much. Do we want to consticize locals in sys_aio_suspend() and args for kern_aio_suspend()?

This revision is now accepted and ready to land.Mar 16 2024, 1:28 AM
brooks added a comment.Mar 19 2024, 10:01 PM
In D44378#1012165, @kib wrote:

Ok, but this change by itself does not change much. Do we want to consticize locals in sys_aio_suspend() and args for kern_aio_suspend()?

This aligns the declaration with aio_suspend(9). It presumably also has the side effect of preventing passing uap->aiocbp argument to copyout without a cast, but my goal here is just to align with the syscall declaration.

Closed by commit rGd8d4ed26c92d: syscall.master: fix aio_suspend signature (authored by brooks). · Explain WhyMar 19 2024, 11:16 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGd8d4ed26c92d: syscall.master: fix aio_suspend signature.

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 135802

View Options

sys/kern/syscalls.master

Loading...