Page MenuHomeFreeBSD
Differential D43338

sys: Use mbufq_empty instead of comparing mbufq_len against 0
ClosedPublic
Actions

Authored by jhb on Jan 5 2024, 9:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 15 2025, 2:46 AM
Unknown Object (File)
Feb 24 2025, 9:14 PM
Unknown Object (File)
Feb 10 2025, 12:54 PM
Unknown Object (File)
Feb 9 2025, 8:55 PM
Unknown Object (File)
Feb 4 2025, 4:58 PM
Unknown Object (File)
Nov 25 2024, 2:17 AM
Unknown Object (File)
Nov 24 2024, 10:05 AM
Unknown Object (File)
Nov 23 2024, 5:57 AM
View All 76 Files
Subscribers
ae
emaste
glebius
imp
melifaro
linuxkpi

Details

Reviewers
bz
markj
emaste
Commits
rG9c50c9b776e3: sys: Use mbufq_empty instead of comparing mbufq_len against 0
rG3c274e9efb46: sys: Use mbufq_empty instead of comparing mbufq_len against 0
rG8cb9b68f5821: sys: Use mbufq_empty instead of comparing mbufq_len against 0

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
2 lines
dev/
cxgb/
4 lines
cxgbe/
tom/
4 lines
net/
2 lines
net80211/
2 lines
6 lines
netinet/
2 lines
netinet6/
2 lines

Diff 132517

View Options

sys/compat/linuxkpi/common/src/linux_80211.c

Show First 20 Lines • Show All 774 Lines • ▼ Show 20 Lines case F_READAHEAD:
*/ */
error = vn_lock(vp, LK_EXCLUSIVE); error = vn_lock(vp, LK_EXCLUSIVE);
if (error != 0) { if (error != 0) {
fdrop(fp, td); fdrop(fp, td);
break; break;
} }
if (arg >= 0) { if (arg >= 0) {
bsize = fp->f_vnode->v_mount->mnt_stat.f_iosize; bsize = fp->f_vnode->v_mount->mnt_stat.f_iosize;
fp->f_seqcount = (arg + bsize - 1) / bsize; arg = MIN(arg, INT_MAX - bsize + 1);
fp->f_seqcount = MIN(IO_SEQMAX,
(arg + bsize - 1) / bsize);
cemUnsubmitted
Not Done
Inline Actions

style(9): 4 space indent on trailing lines

cem: style(9): 4 space indent on trailing lines
atomic_set_int(&fp->f_flag, FRDAHEAD); atomic_set_int(&fp->f_flag, FRDAHEAD);
} else { } else {
atomic_clear_int(&fp->f_flag, FRDAHEAD); atomic_clear_int(&fp->f_flag, FRDAHEAD);
} }
VOP_UNLOCK(vp, 0); VOP_UNLOCK(vp, 0);
fdrop(fp, td); fdrop(fp, td);
break; break;
▲ Show 20 Lines • Show All 3,442 Lines • Show Last 20 Lines
View Options

sys/dev/cxgb/cxgb_sge.c

Show First 20 Lines • Show All 774 Lines • ▼ Show 20 Lines case F_READAHEAD:
*/ */
error = vn_lock(vp, LK_EXCLUSIVE); error = vn_lock(vp, LK_EXCLUSIVE);
if (error != 0) { if (error != 0) {
fdrop(fp, td); fdrop(fp, td);
break; break;
} }
if (arg >= 0) { if (arg >= 0) {
bsize = fp->f_vnode->v_mount->mnt_stat.f_iosize; bsize = fp->f_vnode->v_mount->mnt_stat.f_iosize;
fp->f_seqcount = (arg + bsize - 1) / bsize; arg = MIN(arg, INT_MAX - bsize + 1);
fp->f_seqcount = MIN(IO_SEQMAX,
(arg + bsize - 1) / bsize);
cemUnsubmitted
Not Done
Inline Actions

style(9): 4 space indent on trailing lines

cem: style(9): 4 space indent on trailing lines
atomic_set_int(&fp->f_flag, FRDAHEAD); atomic_set_int(&fp->f_flag, FRDAHEAD);
} else { } else {
atomic_clear_int(&fp->f_flag, FRDAHEAD); atomic_clear_int(&fp->f_flag, FRDAHEAD);
} }
VOP_UNLOCK(vp, 0); VOP_UNLOCK(vp, 0);
fdrop(fp, td); fdrop(fp, td);
break; break;
▲ Show 20 Lines • Show All 3,442 Lines • Show Last 20 Lines
View Options

sys/dev/cxgbe/tom/t4_tom.c

Show First 20 Lines • Show All 774 Lines • ▼ Show 20 Lines case F_READAHEAD:
*/ */
error = vn_lock(vp, LK_EXCLUSIVE); error = vn_lock(vp, LK_EXCLUSIVE);
if (error != 0) { if (error != 0) {
fdrop(fp, td); fdrop(fp, td);
break; break;
} }
if (arg >= 0) { if (arg >= 0) {
bsize = fp->f_vnode->v_mount->mnt_stat.f_iosize; bsize = fp->f_vnode->v_mount->mnt_stat.f_iosize;
fp->f_seqcount = (arg + bsize - 1) / bsize; arg = MIN(arg, INT_MAX - bsize + 1);
fp->f_seqcount = MIN(IO_SEQMAX,
(arg + bsize - 1) / bsize);
cemUnsubmitted
Not Done
Inline Actions

style(9): 4 space indent on trailing lines

cem: style(9): 4 space indent on trailing lines
atomic_set_int(&fp->f_flag, FRDAHEAD); atomic_set_int(&fp->f_flag, FRDAHEAD);
} else { } else {
atomic_clear_int(&fp->f_flag, FRDAHEAD); atomic_clear_int(&fp->f_flag, FRDAHEAD);
} }
VOP_UNLOCK(vp, 0); VOP_UNLOCK(vp, 0);
fdrop(fp, td); fdrop(fp, td);
break; break;
▲ Show 20 Lines • Show All 3,442 Lines • Show Last 20 Lines
View Options

sys/net/if_epair.c

Show First 20 Lines • Show All 774 Lines • ▼ Show 20 Lines case F_READAHEAD:
*/ */
error = vn_lock(vp, LK_EXCLUSIVE); error = vn_lock(vp, LK_EXCLUSIVE);
if (error != 0) { if (error != 0) {
fdrop(fp, td); fdrop(fp, td);
break; break;
} }
if (arg >= 0) { if (arg >= 0) {
bsize = fp->f_vnode->v_mount->mnt_stat.f_iosize; bsize = fp->f_vnode->v_mount->mnt_stat.f_iosize;
fp->f_seqcount = (arg + bsize - 1) / bsize; arg = MIN(arg, INT_MAX - bsize + 1);
fp->f_seqcount = MIN(IO_SEQMAX,
(arg + bsize - 1) / bsize);
cemUnsubmitted
Not Done
Inline Actions

style(9): 4 space indent on trailing lines

cem: style(9): 4 space indent on trailing lines
atomic_set_int(&fp->f_flag, FRDAHEAD); atomic_set_int(&fp->f_flag, FRDAHEAD);
} else { } else {
atomic_clear_int(&fp->f_flag, FRDAHEAD); atomic_clear_int(&fp->f_flag, FRDAHEAD);
} }
VOP_UNLOCK(vp, 0); VOP_UNLOCK(vp, 0);
fdrop(fp, td); fdrop(fp, td);
break; break;
▲ Show 20 Lines • Show All 3,442 Lines • Show Last 20 Lines
View Options

sys/net80211/ieee80211_ddb.c

Loading...
View Options

sys/net80211/ieee80211_ht.c

Loading...
View Options

sys/netinet/igmp.c

Loading...
View Options

sys/netinet6/mld6.c

Loading...