Differential D43336

net80211 amdpu: Simplify a few loops that drain an mbufq
ClosedPublic
Actions

Authored by jhb on Jan 5 2024, 9:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 6, 10:30 PM

	Unknown Object (File)
	Sun, Sep 28, 11:13 AM

	Unknown Object (File)
	Fri, Sep 19, 6:00 PM

	Unknown Object (File)
	Sep 12 2025, 11:51 PM

	Unknown Object (File)
	Aug 20 2025, 7:26 AM

	Unknown Object (File)
	Aug 14 2025, 10:05 PM

	Unknown Object (File)
	Aug 6 2025, 3:42 AM

	Unknown Object (File)
	Jul 18 2025, 9:14 PM

View All 59 Files

Subscribers

Details

Reviewers

bz
markj

Commits

rG2bc7fdc3a8d0: net80211 amdpu: Simplify a few loops that drain an mbufq
rG18df65561983: net80211 amdpu: Simplify a few loops that drain an mbufq
rG6977311633c7: net80211 amdpu: Simplify a few loops that drain an mbufq

Summary

These loops already handled a NULL return from mbufq_dequeue when the
queue was empty, so remove a redundant check of mbufq_len before
dequeueing.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 5 2024, 9:34 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJan 5 2024, 9:34 PM

jhb requested review of this revision.Jan 5 2024, 9:34 PM

jhb added a child revision: D43337: mbuf: Add mbufq_empty.

Harbormaster completed remote builds in B55264: Diff 132350.Jan 5 2024, 9:34 PM

LGTM

This revision is now accepted and ready to land.Jan 6 2024, 4:10 PM

Closed by commit rG6977311633c7: net80211 amdpu: Simplify a few loops that drain an mbufq (authored by jhb). · Explain WhyJan 9 2024, 7:04 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG6977311633c7: net80211 amdpu: Simplify a few loops that drain an mbufq.

jhb added a commit: rG18df65561983: net80211 amdpu: Simplify a few loops that drain an mbufq.Jan 18 2024, 10:40 PM

jhb added a commit: rG2bc7fdc3a8d0: net80211 amdpu: Simplify a few loops that drain an mbufq.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

4 lines

Diff 132515

sys/net80211/ieee80211_ht.c

Loading...