Page MenuHomeFreeBSD
Differential D42316

ndp: improve -c and -d handling in ndp_netlink
ClosedPublic
Actions

Authored by rcm on Oct 20 2023, 1:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 14, 5:28 PM
Unknown Object (File)
Mon, Feb 9, 2:21 AM
Unknown Object (File)
Sat, Jan 31, 6:00 AM
Unknown Object (File)
Sat, Jan 31, 6:00 AM
Unknown Object (File)
Sat, Jan 31, 6:00 AM
Unknown Object (File)
Sat, Jan 31, 2:48 AM
Unknown Object (File)
Dec 11 2025, 6:23 AM
Unknown Object (File)
Dec 7 2025, 10:00 AM
View All Files
Subscribers
imp
pfsense

Details

Reviewers
kp
melifaro
Group Reviewers
network
Commits
rG934a24e55a78: ndp: improve -c and -d handling in ndp_netlink
Summary

This patch restores/fixes some of the behavior present in pre-netlink ndp(8).

  1. Deleting a local address now correctly returns EPERM (instead of ENOENT)
  2. ndp -c no longer dumps the entire table while complaining about local addresses
  3. Return exit code when deleting entry (e.g. trying ndp -d on a local address is an error)

There is still an issue with ndp -s creating duplicate entries. That will be addressed in a separate patch.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rcm created this revision.Oct 20 2023, 1:58 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 20 2023, 1:58 PM
rcm requested review of this revision.Oct 20 2023, 1:58 PM
rcm retitled this revision from ndp: improve -d and -c handling in ndp_netlink to ndp: improve -c and -d handling in ndp_netlink.Oct 20 2023, 2:01 PM
rcm edited the summary of this revision. (Show Details)Oct 20 2023, 2:39 PM
rcm edited the summary of this revision. (Show Details)Oct 21 2023, 2:03 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 23 2023, 8:59 PM
Closed by commit rG934a24e55a78: ndp: improve -c and -d handling in ndp_netlink (authored by rcm, committed by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG934a24e55a78: ndp: improve -c and -d handling in ndp_netlink.

Revision Contents
Changeset List

PathSize
usr.sbin/
ndp/
2 lines
8 lines
13 lines

Diff 129266

View Options

usr.sbin/ndp/ndp.h

Loading...
View Options

usr.sbin/ndp/ndp.c

Loading...
View Options

usr.sbin/ndp/ndp_netlink.c

Loading...