Page MenuHomeFreeBSD
Differential D41435

vm: Allow MAP_32BIT for all architectures
ClosedPublic
Actions

Authored by dchagin on Aug 12 2023, 9:01 AM.
Tags
None
Referenced Files
F163551437: D41435.diff
Fri, Jul 24, 9:46 AM
F163551430: D41435.diff
Fri, Jul 24, 9:46 AM
Unknown Object (File)
Fri, Jul 3, 1:00 AM
Unknown Object (File)
Fri, Jul 3, 12:14 AM
Unknown Object (File)
Thu, Jul 2, 8:49 PM
Unknown Object (File)
Thu, Jul 2, 5:02 PM
Unknown Object (File)
Wed, Jul 1, 3:14 AM
Unknown Object (File)
May 17 2026, 4:56 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
jhb
alc
markj
Commits
rGf3e11927dc28: vm: Allow MAP_32BIT for all architectures

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53079
Build 49970: arc lint + arc unit

Event Timeline

dchagin created this revision.Aug 12 2023, 9:01 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 12 2023, 9:01 AM
dchagin requested review of this revision.Aug 12 2023, 9:01 AM
Harbormaster completed remote builds in B53071: Diff 125930.Aug 12 2023, 9:01 AM
dchagin added a parent revision: D41434: vm: MAP_32BIT_MAX_ADDR defined in sys/mman.h.Aug 12 2023, 9:01 AM
dchagin added a reviewer: kib.Aug 12 2023, 2:57 PM
kib added inline comments.Aug 12 2023, 4:58 PM
sys/vm/vm_mmap.c
1621

I do not think this predict_true is warranted.

kib accepted this revision.Aug 12 2023, 4:58 PM
kib added reviewers: jhb, alc, markj.
This revision is now accepted and ready to land.Aug 12 2023, 4:58 PM
alc added inline comments.Aug 12 2023, 5:34 PM
sys/vm/vm_mmap.c
1621

Agreed, nor is rewriting this to an if/else, as I noted in the other review.

dchagin updated this revision to Diff 125941.Aug 12 2023, 7:52 PM

predict_true macro removed, also fixed libsysdecode mktables

This revision now requires review to proceed.Aug 12 2023, 7:52 PM
Harbormaster completed remote builds in B53079: Diff 125941.Aug 12 2023, 7:52 PM
alc accepted this revision.Aug 12 2023, 8:48 PM
This revision is now accepted and ready to land.Aug 12 2023, 8:48 PM
markj accepted this revision.Aug 14 2023, 1:47 PM
kib accepted this revision.Aug 14 2023, 4:17 PM
Closed by commit rGf3e11927dc28: vm: Allow MAP_32BIT for all architectures (authored by dchagin). · Explain WhyAug 14 2023, 5:21 PM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGf3e11927dc28: vm: Allow MAP_32BIT for all architectures.

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
3 lines
libsysdecode/
9 lines
2 lines
sys/
kern/
8 lines
sys/
2 lines
vm/
17 lines
tests/
sys/
vm/
5 lines
1 line

Diff 125941

View Options

lib/libc/sys/mmap.2

Loading...
View Options

lib/libsysdecode/flags.c

Loading...
View Options

lib/libsysdecode/mktables

Loading...
View Options

sys/kern/uipc_shm.c

Loading...
View Options

sys/sys/mman.h

Loading...
View Options

sys/vm/vm_mmap.c

Loading...
View Options

tests/sys/vm/Makefile

Loading...
View Options

tests/sys/vm/mmap_map_32bit_helper.c

Loading...