Page MenuHomeFreeBSD
Differential D40644

cr_canseeothergids(): Policy change's manual pages impact
ClosedPublic
Actions

Authored by olce on Jun 20 2023, 1:45 PM.
Tags
None
Referenced Files
F163413962: D40644.id123510.diff
Thu, Jul 23, 12:21 AM
F163369784: D40644.id124673.diff
Wed, Jul 22, 2:25 PM
Unknown Object (File)
Tue, Jul 21, 3:43 AM
Unknown Object (File)
Mon, Jul 20, 12:10 AM
Unknown Object (File)
Sun, Jul 19, 4:34 PM
Unknown Object (File)
Fri, Jul 17, 9:25 AM
Unknown Object (File)
Thu, Jul 16, 4:48 AM
Unknown Object (File)
Sat, Jul 11, 8:49 AM
View All Files
Subscribers
emaste
imp
pauamma_chezdork.com
manpages

Details

Reviewers
mjg
kib
dchagin
mhorne
Commits
rG0297e7213c0c: cr_canseeothergids(): Policy change's manual pages impact
rG0452dd841336: cr_canseeothergids(): Policy change's manual pages impact
Summary

See previous commit that made cr_canseeothergids() use the new realgroupmember()
function, taking into account real group IDs instead of effective ones.

PR: 272093

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52661
Build 49552: arc lint + arc unit

Event Timeline

olce created this revision.Jun 20 2023, 1:45 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 20 2023, 1:45 PM
olce requested review of this revision.Jun 20 2023, 1:45 PM
Harbormaster completed remote builds in B52179: Diff 123510.Jun 20 2023, 1:45 PM
olce added a parent revision: D40643: realgroupmember(9): Link to groupmember(9), document the function.Jun 20 2023, 2:11 PM
olce added reviewers: mjg, kib, dchagin.Jun 20 2023, 9:03 PM
emaste added a subscriber: emaste.Jun 29 2023, 4:11 PM
olce added a subscriber: manpages.Jun 29 2023, 8:02 PM
olce added a child revision: D40958: groupmember(), realgroupmember(): Return a bool instead of an int.Jul 10 2023, 3:57 PM
olce updated this revision to Diff 124673.Jul 14 2023, 10:49 AM

Rename cr_bsd_visibility() to cr_bsd_visible().

Harbormaster completed remote builds in B52650: Diff 124673.Jul 14 2023, 10:49 AM
pauamma_chezdork.com added a subscriber: pauamma_chezdork.com.Jul 15 2023, 1:29 AM
pauamma_chezdork.com added inline comments.
share/man/man9/cr_bsd_visible.9
98

While here or as a separate commit: should be "members" to match "credentials" above..

olce mentioned this in D40632: cr_bsd_visible(9): New man page.Jul 16 2023, 10:50 AM
olce updated this revision to Diff 124731.Jul 16 2023, 10:52 AM

Refresh (context).

Harbormaster completed remote builds in B52661: Diff 124731.Jul 16 2023, 10:52 AM
olce marked an inline comment as done.Jul 16 2023, 10:53 AM
olce added inline comments.
share/man/man9/cr_bsd_visible.9
98

Fixed in D40632 directly.

olce updated this revision to Diff 124904.Jul 20 2023, 10:39 AM
olce marked an inline comment as done.
olce retitled this revision from cr_seeothergids(): Policy change's manual pages impact to cr_canseeothergids(): Policy change's manual pages impact.
olce edited the summary of this revision. (Show Details)

'cr_see*' => 'cr_cansee*' (suppressed a rename in the stack).

Harbormaster completed remote builds in B52741: Diff 124904.Jul 20 2023, 10:39 AM
mhorne accepted this revision.Jul 21 2023, 6:36 PM
This revision is now accepted and ready to land.Jul 21 2023, 6:36 PM
Closed by commit rG0452dd841336: cr_canseeothergids(): Policy change's manual pages impact (authored by olce, committed by mhorne). · Explain WhySep 28 2023, 3:12 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG0452dd841336: cr_canseeothergids(): Policy change's manual pages impact.
mhorne mentioned this in rGf482bc958437: cr_canseeothergids(): Use real instead of effective group membership.Oct 17 2023, 7:44 PM
mhorne mentioned this in rG26ff4836c888: cr_canseeothergids(): Use real instead of effective group membership.Oct 18 2023, 6:10 PM
olce added a commit: rG0297e7213c0c: cr_canseeothergids(): Policy change's manual pages impact.Dec 21 2023, 1:46 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
2 lines
8 lines

Diff 124731

View Options

share/man/man9/cr_bsd_visible.9

Loading...
View Options

share/man/man9/cr_seeothergids.9

Loading...