Paths

Table of Contentst

Differential D39483

epair tests: test PCP tagged packets
ClosedPublic
Actions

Authored by kp on Apr 10 2023, 1:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 6, 4:39 AM

	Unknown Object (File)
	Sun, Sep 6, 1:39 AM

	Unknown Object (File)
	Sat, Sep 5, 2:58 PM

	Unknown Object (File)
	Sat, Sep 5, 11:09 AM

	Unknown Object (File)
	Sat, Sep 5, 7:25 AM

	Unknown Object (File)
	Sat, Sep 5, 3:30 AM

	Unknown Object (File)
	Fri, Sep 4, 6:01 PM

	Unknown Object (File)
	Thu, Sep 3, 12:53 PM

Subscribers

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rGc79831b38a63: epair tests: test PCP tagged packets
rGd116b8430b90: epair tests: test PCP tagged packets

Summary

PR: 270736
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 50816
Build 47707: arc lint + arc unit

Event Timeline

kp created this revision.Apr 10 2023, 1:05 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptApr 10 2023, 1:05 PM

kp requested review of this revision.Apr 10 2023, 1:05 PM

Harbormaster completed remote builds in B50816: Diff 120074.Apr 10 2023, 1:05 PM

kp mentioned this in D39482: if_epair: also remove vlan metadata from packets.Apr 10 2023, 2:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2023, 3:56 PM

Closed by commit rGd116b8430b90: epair tests: test PCP tagged packets (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGd116b8430b90: epair tests: test PCP tagged packets.

zlei added inline comments.Apr 11 2023, 1:01 AM

tests/sys/net/if_epair_test.sh
53	This comment is misleading. Actually same PCP can also lead the problem. When I reported, I intended to debug / observe (via tcpdump) how the PCP is tagged. A different PCP is useful.
55	Sorry for late response. In case the test fails (regression), does `ping` need a timeout option to prevent too long delay before it returns ?

kp added a commit: rGc79831b38a63: epair tests: test PCP tagged packets.Apr 18 2023, 7:23 AM

Revision Contents
Changeset List

Path

Size

tests/

sys/

net/

1 line

if_epair_test.sh

65 lines

Diff 120074

tests/sys/net/Makefile

Loading...

tests/sys/net/if_epair_test.sh

Loading...