Differential D38714

linux(4): Consolidate a FreeBSD interface names translation code
ClosedPublic
Actions

Authored by dchagin on Feb 21 2023, 10:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 1, 5:37 AM

	Unknown Object (File)
	Tue, Sep 29, 2:59 AM

	Unknown Object (File)
	Sun, Sep 27, 10:31 AM

	Unknown Object (File)
	Sat, Sep 26, 7:26 AM

	Unknown Object (File)
	Thu, Sep 24, 7:56 AM

	Unknown Object (File)
	Thu, Sep 24, 7:17 AM

	Unknown Object (File)
	Thu, Sep 24, 6:31 AM

	Unknown Object (File)
	Thu, Sep 24, 5:47 AM

Subscribers

Details

Reviewers

melifaro
jhibbits

Group Reviewers

Linux Emulation

Commits

rGaeed04a32e45: linux(4): Consolidate a FreeBSD interface names translation code
rGa83551a52d1c: linux(4): Consolidate a FreeBSD interface names translation code
rG3ab3c9c29cf0: linux(4): Consolidate a FreeBSD interface names translation code

Summary

We have some amount of interface names translation functions which are
differs by bugs implementation. Consolidates it in a one place.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 49959
Build 46851: arc lint + arc unit

Event Timeline

dchagin created this revision.Feb 21 2023, 10:29 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 21 2023, 10:29 PM

dchagin requested review of this revision.Feb 21 2023, 10:29 PM

Harbormaster completed remote builds in B49936: Diff 117718.Feb 21 2023, 10:29 PM

@jhibbits, I also reverted 52435989, as linprocfs code also needed to update

In D38714#881069, @dchagin wrote:

@jhibbits, I also reverted 52435989, as linprocfs code also needed to update

I just reverted that, so you can simplify your diff.

Initialize ret to 0 for case when nothing is found

Harbormaster completed remote builds in B49945: Diff 117741.Feb 22 2023, 8:29 AM

Otimized, ethno calculated in callers to avoid one for over ifnets

Harbormaster completed remote builds in B49947: Diff 117744.Feb 22 2023, 10:10 AM

melifaro added inline comments.Feb 22 2023, 11:14 AM

sys/compat/linux/linux.c
249	Nit: ‘const char *bsdname’. It would help to understand whar ‘len’ refers to

ifnet_byindex, ifuint instead of handmade,
also use net ecoch in modified code, others later

Harbormaster completed remote builds in B49955: Diff 117752.Feb 22 2023, 12:01 PM

fix ifconf, btw, ifconf is no more used by glibc, replaced by netlink...

Harbormaster completed remote builds in B49958: Diff 117755.Feb 22 2023, 12:05 PM

ugh, fie net epoch in linprocfs donetroute, tested

Harbormaster completed remote builds in B49959: Diff 117756.Feb 22 2023, 12:11 PM

melifaro accepted this revision.Feb 22 2023, 12:52 PM

melifaro added inline comments.

sys/compat/linux/linux.c
308	There can be more that one loopback interface, so I guess we need to rename only the first one (e.g. "lo0") and keep the rest intact.
sys/compat/linux/linux_ioctl.c
2170

This revision is now accepted and ready to land.Feb 22 2023, 12:52 PM

fix lo -> lo0, loX -> loX translation

This revision now requires review to proceed.Feb 22 2023, 1:54 PM

Harbormaster completed remote builds in B49961: Diff 117762.Feb 22 2023, 1:54 PM

dchagin added a child revision: D38735: linux(4): Migrate to IfAPI.Feb 22 2023, 8:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2023, 8:01 AM

Closed by commit rG3ab3c9c29cf0: linux(4): Consolidate a FreeBSD interface names translation code (authored by dchagin). · Explain Why

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG3ab3c9c29cf0: linux(4): Consolidate a FreeBSD interface names translation code.

dchagin added a commit: rGa83551a52d1c: linux(4): Consolidate a FreeBSD interface names translation code.Feb 26 2023, 8:12 AM

dchagin added a commit: rGaeed04a32e45: linux(4): Consolidate a FreeBSD interface names translation code.Feb 27 2023, 6:16 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linprocfs/

40 lines

linux/

77 lines

4 lines

56 lines

Diff 117756

sys/compat/linprocfs/linprocfs.c

Loading...

sys/compat/linux/linux.c

Loading...

sys/compat/linux/linux_common.h

Loading...

sys/compat/linux/linux_ioctl.c

Loading...