Page MenuHomeFreeBSD
Differential D38327

bhyve: add helper struct for acpi device handling
ClosedPublic
Actions

Authored by corvink on Feb 1 2023, 11:09 AM.
Tags
None
Referenced Files
F166704576: D38327.id117181.diff
Sat, Aug 15, 7:02 PM
Unknown Object (File)
Sat, Aug 8, 5:04 PM
Unknown Object (File)
Sat, Aug 8, 5:03 PM
Unknown Object (File)
Sat, Aug 8, 4:33 PM
Unknown Object (File)
Sat, Aug 8, 4:21 PM
Unknown Object (File)
Sat, Aug 8, 11:06 AM
Unknown Object (File)
Thu, Aug 6, 10:18 PM
Unknown Object (File)
Thu, Aug 6, 10:18 PM
View All Files
Subscribers
bcran
imp
rew
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rGb5d47fa9a511: bhyve: add helper struct for acpi device handling
rG1231f047c3ed: bhyve: add helper struct for acpi device handling
Summary

To simplify the handling of different acpi devices like qemu fwcfg or a
tpm, add a helper struct. It will handle the reporting of acpi
resources.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49588
Build 46478: arc lint + arc unit

Event Timeline

corvink created this revision.Feb 1 2023, 11:09 AM
Herald added a reviewer: bhyve. · View Herald TranscriptFeb 1 2023, 11:09 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
corvink requested review of this revision.Feb 1 2023, 11:09 AM
Harbormaster completed remote builds in B49399: Diff 116183.Feb 1 2023, 11:09 AM
corvink mentioned this in D33767: bhyve: add helper struct for ACPI device handling.Feb 1 2023, 11:13 AM
corvink added a child revision: D38328: bhyve: add helper func to add acpi resources.
markj added inline comments.Feb 1 2023, 3:49 PM
usr.sbin/bhyve/acpi_device.c
10

You don't need to add this to new files.

12

No need to include sys/types.h if you include sys/param.h. See style(9).

98

Don't you want to free the acpi_device itself?

corvink updated this revision to Diff 116332.Feb 2 2023, 2:06 PM
  • fix includes
  • save copies of name and hid in acpi_device_create
  • properly free an acpi_device on acpi_device_destroy
corvink marked 3 inline comments as done.Feb 2 2023, 2:06 PM
Harbormaster completed remote builds in B49478: Diff 116332.Feb 2 2023, 2:06 PM
markj added inline comments.Feb 2 2023, 2:12 PM
usr.sbin/bhyve/acpi_device.c
101

Double free.

rew added a subscriber: rew.Feb 6 2023, 9:41 PM
rew added inline comments.
usr.sbin/bhyve/acpi_device.c
101

I'm guessing its a typo since dev->name is strdup()'ed further up.

corvink updated this revision to Diff 116677.Feb 7 2023, 7:42 AM
  • fix typo in free call
Harbormaster completed remote builds in B49588: Diff 116677.Feb 7 2023, 7:42 AM
corvink marked 2 inline comments as done.Feb 7 2023, 7:46 AM
corvink added inline comments.
usr.sbin/bhyve/acpi_device.c
101

Yes, it was a typo.

markj accepted this revision as: markj.Feb 10 2023, 4:06 PM
This revision is now accepted and ready to land.Feb 10 2023, 4:06 PM
Closed by commit rG1231f047c3ed: bhyve: add helper struct for acpi device handling (authored by corvink). · Explain WhyFeb 14 2023, 7:29 AM
This revision was automatically updated to reflect the committed changes.
corvink marked an inline comment as done.
corvink added a commit: rG1231f047c3ed: bhyve: add helper struct for acpi device handling.
corvink added a commit: rGb5d47fa9a511: bhyve: add helper struct for acpi device handling.Feb 28 2023, 10:14 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
1 line
31 lines
92 lines

Diff 116677

View Options

usr.sbin/bhyve/Makefile

Loading...
View Options

usr.sbin/bhyve/acpi_device.h

Loading...
View Options

usr.sbin/bhyve/acpi_device.c

Loading...