Differential D38348

IfAPI: Add iterator to loop over all interfaces
ClosedPublic
Actions

Authored by jhibbits on Feb 1 2023, 9:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 27, 9:54 AM

	Unknown Object (File)
	Thu, Apr 23, 11:24 AM

	Unknown Object (File)
	Wed, Apr 22, 12:14 PM

	Unknown Object (File)
	Wed, Apr 22, 12:57 AM

	Unknown Object (File)
	Tue, Apr 21, 11:53 AM

	Unknown Object (File)
	Mon, Apr 20, 4:46 PM

	Unknown Object (File)
	Fri, Apr 17, 8:07 AM

	Unknown Object (File)
	Tue, Apr 14, 11:33 PM

Subscribers

Details

Reviewers

glebius
melifaro

Group Reviewers

Commits

rG2eeb808361e4: IfAPI: Add iterator to loop over all interfaces

Summary

Sometimes it's useful to iterate over all interfaces in the current
VNET, as the linuxulator does in several places.

Unlike other iterators in the IfAPI this propagates any error received
up to the caller, instead of returning a count.

Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49429
Build 46319: arc lint + arc unit

Event Timeline

jhibbits created this revision.Feb 1 2023, 9:31 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptFeb 1 2023, 9:31 PM

jhibbits requested review of this revision.Feb 1 2023, 9:31 PM

Harbormaster completed remote builds in B49429: Diff 116229.Feb 1 2023, 9:31 PM

Add missing bits...

Harbormaster completed remote builds in B49431: Diff 116231.Feb 1 2023, 9:39 PM

melifaro accepted this revision.Feb 1 2023, 10:35 PM

melifaro added inline comments.

sys/net/if.c
4480	Nit: worth asserting net epoch and cb!=null

This revision is now accepted and ready to land.Feb 1 2023, 10:35 PM

jhibbits mentioned this in D38349: Port Linuxulator to IfAPI.Feb 2 2023, 4:38 PM

glebius added inline comments.Feb 2 2023, 8:24 PM

sys/net/if.c
4480	Not sure about asserting the cb, as it would crash anyway. But the NET_EPOCH_ASSERT() needs to be here.
sys/net/if_var.h
510	I'd suggest to name the function if_foreach() and typedef as if_foreach_cb_t. The reason why I'd suggest to avoid "ifnet" is that a code that is fully converted to the new API should return empty on grep ifnet foo.c. That was suggested back in 2012 and it still works - just checked the drivers you recently converted. I'd also suggest to place these declarations down at line 667, where the address iterating functions are declared.

jhibbits added inline comments.Feb 2 2023, 9:10 PM

sys/net/if_var.h
510	I was also thinking if_foreach(), and hesitated because it doesn't convey "foreach what?" and all other "if_" functions in the IfAPI act on a single interface. But just as happy to make the change, and move it.

if_foreach_ifp ?

In D38348#871789, @melifaro wrote:

if_foreach_ifp ?

The prefix already stands for interface, so why the tautology?

Address @glebius's feedback.

This revision now requires review to proceed.Feb 2 2023, 9:42 PM

Harbormaster completed remote builds in B49491: Diff 116366.Feb 2 2023, 9:42 PM

glebius accepted this revision as: glebius.Feb 2 2023, 11:47 PM

This revision is now accepted and ready to land.Feb 2 2023, 11:47 PM

Closed by commit rG2eeb808361e4: IfAPI: Add iterator to loop over all interfaces (authored by jhibbits). · Explain WhyFeb 3 2023, 2:46 PM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rG2eeb808361e4: IfAPI: Add iterator to loop over all interfaces.

Revision Contents
Changeset List

Path

Size

sys/

net/

15 lines

3 lines

Diff 116229

sys/net/if.c

Loading...

sys/net/if_var.h

Loading...