find: Add GNU find's -printf
ClosedPublic
Actions

Authored by imp on Jan 20 2023, 7:50 PM.

Details

Reviewers

emaste
jrtc27
des
gbe
eugen_grosbein.net
ceri
0mp
arichardson
jilles
cem
delphij
bapt

Commits

rG7b9c912c41f4: find: Add GNU find's -printf

Summary

Implements most of gnu find's -printf predicate. However, the '#', '-',
'.' and size format modifiers are unimplemented, as are %P, %H, %F, %y,
and %Y formats. Follows what I think it should do based on the info
page, I've not looked at the gnu find code.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49185
Build 46074: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jan 20 2023, 7:50 PM

imp created this revision.

Harbormaster completed remote builds in B49185: Diff 115368.Jan 20 2023, 7:50 PM

imp edited the summary of this revision. (Show Details)Jan 20 2023, 7:51 PM

bapt added a subscriber: bapt.Jan 20 2023, 8:32 PM

bapt added inline comments.

usr.bin/find/Makefile
16	probably added by accident :D
17	nitpicking here, but maybe consider open_memstream instead of sbuf? it will avoid adding an extra link to sbuf library for a very limited usage. feel free to totally ignore this nitpicking comment

emaste added a subscriber: emaste.Jan 20 2023, 9:01 PM

use open_memstream

Harbormaster completed remote builds in B54507: Diff 130292.Nov 18 2023, 5:27 AM

imp added inline comments.Nov 18 2023, 5:28 AM

usr.bin/find/Makefile
17	Sure. I resisted for a while, but the conversion was quicker than arguing :)

imp edited the test plan for this revision. (Show Details)Nov 18 2023, 5:33 AM

imp added reviewers: emaste, jrtc27, des, gbe, eugen_grosbein.net, ceri, 0mp, arichardson, jilles, cem, delphij, bapt.

imp marked 2 inline comments as done.

jrtc27 added inline comments.Nov 18 2023, 5:48 AM

usr.bin/find/printf.c
106	\\ needs to be special-cased to not warn
144

jilles added inline comments.Dec 1 2023, 3:01 PM

usr.bin/find/function.c
1417	We only need to force stat if certain formats are used. If it's just `%p`/`%f`/`%h` and literals, no stat calls are necessary.
usr.bin/find/printf.c
271	This will run off the end of the string if `*fmt == '\0'`.
283	typo

Usually LGTM, besides the part of the XXX (see comment).

usr.bin/find/find.1
1043	This should be written out or removed. Otherwise LGTM.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 25 2025, 4:35 PM

Closed by commit rG7b9c912c41f4: find: Add GNU find's -printf (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG7b9c912c41f4: find: Add GNU find's -printf.

Herald added a subscriber: ziaee. · View Herald TranscriptJul 25 2025, 4:35 PM

imp added inline comments.Jul 25 2025, 10:26 PM

usr.bin/find/function.c
1417	Oh my. Seems like I overlooked this. Fixed in a followup commit. Thanks for catching it.
usr.bin/find/printf.c
106	I'm not sure how to parse this. Can you say again in another way?