stand: Create common gen_setcurrdev and replace code
ClosedPublic
Actions

Authored by imp on Jan 10 2023, 12:18 AM.

Details

Reviewers

kevans
manu
fuz

Group Reviewers

bhyve

Commits

rGab377e0e5168: stand: Create common gen_setcurrdev and replace code
rG1c1783d66bc8: stand: Create common gen_setcurrdev and replace code

Summary

Replace 4 identical copies of *_setcurrdev with gen_setcurrdev to avoid
having to create a 5th copy. uboot_setcurrdev is actually different and
needs to remain separate (even though it's quite similar).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49031
Build 45920: arc lint + arc unit

Event Timeline

imp created this revision.Jan 10 2023, 12:18 AM

Herald added a reviewer: manu. · View Herald TranscriptJan 10 2023, 12:18 AM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

imp requested review of this revision.Jan 10 2023, 12:18 AM

Harbormaster completed remote builds in B49031: Diff 114912.Jan 10 2023, 12:18 AM

imp added a child revision: D38004: stand: Move dev_cleanup into libsa.Jan 10 2023, 12:18 AM

kevans accepted this revision.Jan 11 2023, 12:15 AM

This revision is now accepted and ready to land.Jan 11 2023, 12:15 AM

Tested ok on arm64. Changes look fine.

imp retitled this revision from stand: Create common gen_setcurrdev and remplace code to stand: Create common gen_setcurrdev and replace code.Jan 11 2023, 10:08 PM

Closed by commit rG1c1783d66bc8: stand: Create common gen_setcurrdev and replace code (authored by imp). · Explain WhyJan 11 2023, 10:17 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG1c1783d66bc8: stand: Create common gen_setcurrdev and replace code.

imp added a commit: rGab377e0e5168: stand: Create common gen_setcurrdev and replace code.Jan 24 2023, 10:21 PM