Page MenuHomeFreeBSD
Differential D37314

tcp: account sent/received IP ECN markings independently
ClosedPublic
Actions

Authored by rscheff on Nov 9 2022, 11:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 3:13 PM
Unknown Object (File)
Mon, Sep 7, 1:32 AM
Unknown Object (File)
Sun, Sep 6, 9:06 PM
Unknown Object (File)
Sun, Sep 6, 2:07 PM
Unknown Object (File)
Sun, Sep 6, 10:07 AM
Unknown Object (File)
Sat, Sep 5, 1:57 PM
Unknown Object (File)
Fri, Sep 4, 4:32 AM
Unknown Object (File)
Thu, Sep 3, 10:07 PM
View All Files
Subscribers
imp
melifaro

Details

Reviewers
rrs
jtl
glebius
• hselasky
tuexen
Group Reviewers
transport
Commits
rG1a70101a8700: tcp: account sent/received IP ECN markings independently
Summary

TCPS (netstat -s) would not differentiate between received and sent
ECN-marked packets, but would only account received packets if the
tcp session had negotiated ECN support.

It is known that some devices incorrectly set the historic TOS byte
and may infringe on the IP ECN bits - but without accounting IP ECN
packets where the session is not ECN-enabled would mask such misconfigurations.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48242
Build 45128: arc lint + arc unit

Event Timeline

rscheff created this revision.Nov 9 2022, 11:22 AM
Herald added a reviewer: transport. · View Herald TranscriptNov 9 2022, 11:22 AM
Herald added subscribers: melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Nov 9 2022, 11:22 AM
Harbormaster completed remote builds in B48239: Diff 112798.Nov 9 2022, 11:22 AM
rscheff added inline comments.Nov 9 2022, 12:08 PM
sys/netinet/tcp_var.h
828

not sure if we will need a sent ce counter - this may only be relevant for future CC where a receiver driving marking is also possible. Or for path probing...

rscheff updated this revision to Diff 112801.Nov 9 2022, 3:32 PM
  • remove tcps_ecn_sndce
Harbormaster completed remote builds in B48240: Diff 112801.Nov 9 2022, 3:32 PM
tuexen added inline comments.Nov 9 2022, 3:46 PM
sys/netinet/tcp_ecn.c
124

Why are you removing this line?

sys/netinet/tcp_var.h
831

I think you want to go from 6 to 4 now, not to 3.

However, wasn't the plan to not change this at all in the main branch?

usr.bin/netstat/inet.c
831

Don't you need to change the "\t{:*/%ju} " stuff?

rscheff updated this revision to Diff 112806.Nov 9 2022, 4:42 PM
  • fix oversights
Harbormaster completed remote builds in B48241: Diff 112806.Nov 9 2022, 4:42 PM
rscheff updated this revision to Diff 112808.Nov 9 2022, 4:43 PM
  • comment typo
Harbormaster completed remote builds in B48242: Diff 112808.Nov 9 2022, 4:43 PM
rscheff marked 3 inline comments as done.Nov 9 2022, 4:43 PM
glebius accepted this revision.Nov 9 2022, 11:09 PM
tuexen accepted this revision.Nov 10 2022, 9:20 AM
This revision is now accepted and ready to land.Nov 10 2022, 9:20 AM
Closed by commit rG1a70101a8700: tcp: account sent/received IP ECN markings independently (authored by rscheff). · Explain WhyNov 10 2022, 11:10 AM
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rG1a70101a8700: tcp: account sent/received IP ECN markings independently.

Revision Contents
Changeset List

PathSize
sys/
netinet/
40 lines
12 lines
usr.bin/
netstat/
16 lines

Diff 112808

View Options

sys/netinet/tcp_ecn.c

Loading...
View Options

sys/netinet/tcp_var.h

Loading...
View Options

usr.bin/netstat/inet.c

Loading...