Page MenuHomeFreeBSD
Differential D37156

vmm: Expose struct vcpu as an opaque type.
ClosedPublic
Actions

Authored by jhb on Oct 27 2022, 3:04 PM.
Tags
None
Referenced Files
F110745654: D37156.diff
Sat, Feb 22, 2:11 PM
F110745328: D37156.id.diff
Sat, Feb 22, 2:08 PM
F110743657: D37156.id112265.diff
Sat, Feb 22, 1:53 PM
F110742709: D37156.id113299.diff
Sat, Feb 22, 1:43 PM
F110742527: D37156.id112624.diff
Sat, Feb 22, 1:41 PM
Unknown Object (File)
Fri, Jan 24, 5:42 PM
Unknown Object (File)
Jan 22 2025, 1:03 PM
Unknown Object (File)
Jan 20 2025, 4:08 PM
View All 83 Files
Subscribers
bcran
corvink
imp
rgrimes

Details

Reviewers
markj
corvink
Group Reviewers
bhyve
Commits
rGfa1eabaa8d9a: vmm: Expose struct vcpu as an opaque type.
rG950af9ffc616: vmm: Expose struct vcpu as an opaque type.
Summary

Pass a pointer to the current struct vcpu to the vcpu_init callback
and save this pointer in the CPU-specific vcpu structures.

Add routines to fetch a struct vcpu by index from a VM and to query
the VM and vcpuid from a struct vcpu.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48161
Build 45048: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 27 2022, 3:04 PM
Herald added a reviewer: bhyve. · View Herald TranscriptOct 27 2022, 3:04 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
jhb requested review of this revision.Oct 27 2022, 3:04 PM
Harbormaster completed remote builds in B48028: Diff 112265.Oct 27 2022, 3:04 PM
jhb added a parent revision: D37155: vmm: Use VLAPIC_CTR* in more places..Oct 27 2022, 3:04 PM
jhb added a child revision: D37157: vmm: Use struct vcpu with the vmm_stat API..
corvink added a subscriber: corvink.Nov 2 2022, 10:09 AM
corvink added inline comments.
sys/amd64/vmm/vmm.c
2331

Nit: vcpuid might be clearer.

markj accepted this revision as: markj.Nov 4 2022, 3:08 PM
This revision is now accepted and ready to land.Nov 4 2022, 3:08 PM
jhb marked an inline comment as done.Nov 4 2022, 9:17 PM
jhb updated this revision to Diff 112624.Nov 4 2022, 9:19 PM

Use vcpuid

This revision now requires review to proceed.Nov 4 2022, 9:19 PM
Harbormaster completed remote builds in B48161: Diff 112624.Nov 4 2022, 9:19 PM
corvink accepted this revision.Nov 7 2022, 7:14 AM
This revision is now accepted and ready to land.Nov 7 2022, 7:14 AM
markj accepted this revision as: markj.Nov 11 2022, 3:50 PM
Closed by commit rG950af9ffc616: vmm: Expose struct vcpu as an opaque type. (authored by jhb). · Explain WhyNov 18 2022, 6:27 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG950af9ffc616: vmm: Expose struct vcpu as an opaque type..
jhb added a commit: rGfa1eabaa8d9a: vmm: Expose struct vcpu as an opaque type..Jan 26 2023, 10:12 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
7 lines
vmm/
amd/
4 lines
1 line
intel/
1 line
4 lines
io/
2 lines
42 lines

Diff 112624

View Options

sys/amd64/include/vmm.h

Loading...
View Options

sys/amd64/vmm/amd/svm.c

Loading...
View Options

sys/amd64/vmm/amd/svm_softc.h

Loading...
View Options

sys/amd64/vmm/intel/vmx.h

Loading...
View Options

sys/amd64/vmm/intel/vmx.c

Loading...
View Options

sys/amd64/vmm/io/vlapic_priv.h

Loading...
View Options

sys/amd64/vmm/vmm.c

Loading...