vmm vmx: Add VMX_CTR* wrapper macros.
ClosedPublic
Actions

Authored by jhb on Oct 27 2022, 3:03 PM.

Details

Reviewers

markj
corvink

Group Reviewers

bhyve

Commits

rG11940aaeb0de: vmm vmx: Add VMX_CTR* wrapper macros.
rG57e0119ef3a9: vmm vmx: Add VMX_CTR* wrapper macros.

Summary

These macros are similar to VCPU_CTR* but accept a single vmx_vcpu
pointer as the first argument instead of separate vm and vcpuid.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48026
Build 44913: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 27 2022, 3:03 PM

Herald added a reviewer: bhyve. · View Herald TranscriptOct 27 2022, 3:03 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Oct 27 2022, 3:03 PM

Harbormaster completed remote builds in B48026: Diff 112263.Oct 27 2022, 3:03 PM

jhb added a parent revision: D37153: vmm svm: Add SVM_CTR* wrapper macros..Oct 27 2022, 3:03 PM

jhb added a child revision: D37155: vmm: Use VLAPIC_CTR* in more places..

markj accepted this revision as: markj.Nov 4 2022, 2:51 PM

markj added inline comments.

sys/amd64/vmm/intel/vmx.c
1238	Are these ifdefs needed?

This revision is now accepted and ready to land.Nov 4 2022, 2:51 PM

jhb added inline comments.Nov 4 2022, 8:56 PM

sys/amd64/vmm/intel/vmx.c
1238	Hmm, no.

jhb marked an inline comment as done.Nov 4 2022, 9:15 PM

jhb added inline comments.

sys/amd64/vmm/intel/vmx.c
1238	I added a followup commit to trim them.

corvink accepted this revision.Nov 11 2022, 11:59 AM

Closed by commit rG57e0119ef3a9: vmm vmx: Add VMX_CTR* wrapper macros. (authored by jhb). · Explain WhyNov 18 2022, 6:27 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG57e0119ef3a9: vmm vmx: Add VMX_CTR* wrapper macros..

jhb added a commit: rG11940aaeb0de: vmm vmx: Add VMX_CTR* wrapper macros..Jan 26 2023, 10:12 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

intel/

vmx.h

15 lines

vmx.c

78 lines

Diff 112263

View Options

sys/amd64/vmm/intel/vmx.h