Page MenuHomeFreeBSD
Differential D36139

ixgbe: fix software vlan handling
ClosedPublic
Actions

Authored by kp on Aug 11 2022, 1:16 PM.
Tags
None
Referenced Files
F105943255: D36139.diff
Sun, Dec 22, 9:59 PM
Unknown Object (File)
Mon, Nov 25, 2:04 PM
Unknown Object (File)
Sun, Nov 24, 4:02 AM
Unknown Object (File)
Nov 23 2024, 1:21 AM
Unknown Object (File)
Nov 8 2024, 6:41 AM
Unknown Object (File)
Oct 29 2024, 3:36 PM
Unknown Object (File)
Oct 21 2024, 4:22 PM
Unknown Object (File)
Oct 18 2024, 1:12 PM
View All 82 Files
Subscribers
ae
afedorov
imp

Details

Reviewers
None
Group Reviewers
network
pfsense
Intel Networking
Restricted Owners Package(Owns No Changed Paths)
Commits
rGe7abb897018b: ixgbe: fix software vlan handling
Summary

If hardware vlan tagging is disabled (after a vlan has been added) we
receive double-tagged packets, even if the packet on the wire only has a

single VLAN tag. That looks like this:

17:29:30.370787 00:51:82:11:22:02 > 90:ec:77:1f:8a:5f, ethertype 802.1Q (0x8100), length 64: vlan 0, p 0, ethertype 802.1Q, vlan 1001, p 0, ethertype ARP, Ethernet (len 6), IPv4 (len 4), Reply 10.101.0.12 is-at 00:51:82:11:22:02, length 42

This happens because the ixgbe driver does not clear the vlan flags in
the hardware (such as IXGBE_RXDCTL_VME) if IFCAP_VLAN_HWTAGGING is
cleared.

Add code to do so, which fixes this issue.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Aug 11 2022, 1:16 PM
Herald added subscribers: ae, imp. · View Herald TranscriptAug 11 2022, 1:16 PM
kp requested review of this revision.Aug 11 2022, 1:16 PM
Harbormaster completed remote builds in B46858: Diff 109154.Aug 11 2022, 1:16 PM
afedorov added a subscriber: afedorov.Aug 11 2022, 1:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 17 2022, 2:40 PM
Closed by commit rGe7abb897018b: ixgbe: fix software vlan handling (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGe7abb897018b: ixgbe: fix software vlan handling.
Owners added a reviewer: Restricted Owners Package.Aug 17 2022, 2:40 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
ixgbe/
21 lines

Diff 109459

View Options

sys/dev/ixgbe/if_ix.c

Loading...