Differential D34873

nvme: Use controller's page size instead of PAGE_SIZE to create qpair
ClosedPublic
Actions

Authored by imp on Apr 10 2022, 5:12 PM.

Tags

None

Referenced Files

	F157582098: D34873.id105071.diff
	Sat, May 23, 1:49 AM

	F157520236: D34873.id104849.diff
	Fri, May 22, 8:27 AM

	Unknown Object (File)
	Thu, May 21, 2:03 AM

	Unknown Object (File)
	Mon, May 18, 5:35 PM

	Unknown Object (File)
	Wed, May 13, 7:32 PM

	Unknown Object (File)
	Wed, May 13, 7:32 PM

	Unknown Object (File)
	Wed, May 13, 7:31 PM

	Unknown Object (File)
	Sat, May 9, 8:51 AM

Subscribers

Details

Reviewers

mav
chuck
gallatin
chs
andrew
jimharris
rpokala

Commits

rG0fd4cd405bbf: nvme: Use controller's page size instead of PAGE_SIZE to create qpair

Summary

When constructing qpair, use the controller's notion of page size rather
than the host's PAGE_SIZE. Currently, these are both 4k, but the arm 16k
page size support requires decoupling.

There's a "hidden" PAGE_SIZE in btoc, so we must change btoc(x) to
howmany(x, ctrlr->page_size) to properly count the number of pages (in
the drive's world view) are needed for various calculations.

Sponsored by: Netflix

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45114
Build 42002: arc lint + arc unit

Event Timeline

imp created this revision.Apr 10 2022, 5:12 PM

Herald added a subscriber: dab. · View Herald TranscriptApr 10 2022, 5:12 PM

imp requested review of this revision.Apr 10 2022, 5:12 PM

Harbormaster completed remote builds in B45114: Diff 104849.Apr 10 2022, 5:12 PM

imp added a parent revision: D34872: nvme: Prefer nvme_printf to printf when reporting formatting error.Apr 10 2022, 5:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 15 2022, 8:48 PM

Closed by commit rG0fd4cd405bbf: nvme: Use controller's page size instead of PAGE_SIZE to create qpair (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG0fd4cd405bbf: nvme: Use controller's page size instead of PAGE_SIZE to create qpair.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

27 lines

Diff 104849

sys/dev/nvme/nvme_qpair.c

Loading...