Page MenuHomeFreeBSD

tcp/syncache: Set flowid and hash type properly for SYN|ACK
ClosedPublic

Authored by sepherosa_gmail.com on Apr 27 2016, 8:45 AM.
Tags
None
Referenced Files
F103549901: D6120.diff
Tue, Nov 26, 9:59 AM
Unknown Object (File)
Oct 27 2024, 11:52 AM
Unknown Object (File)
Oct 3 2024, 9:45 AM
Unknown Object (File)
Oct 3 2024, 4:18 AM
Unknown Object (File)
Sep 30 2024, 4:39 PM
Unknown Object (File)
Sep 16 2024, 6:27 AM
Unknown Object (File)
Sep 14 2024, 6:21 AM
Unknown Object (File)
Sep 9 2024, 8:59 AM

Details

Summary

So the underlying drivers can use it to select the sending queue properly for SYN|ACK instead of rolling their own hash.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to tcp/syncache: Set flowid and hash type properly for SYN|ACK.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sbruno added a reviewer: sbruno.
hiren edited edge metadata.

I hope you'd write a bit more descriptive commit-log (not just 'what' but also 'why') for the change. Thanks a lot for your work!

Cheers,
Hiren

sys/netinet/tcp_syncache.c
1507 ↗(On Diff #15647)

Do you mind adding a line or two about what this function does in comments to improve readability? Thanks :-)

This revision is now accepted and ready to land.Apr 28 2016, 10:33 PM
In D6120#130786, @hiren wrote:

I hope you'd write a bit more descriptive commit-log (not just 'what' but also 'why') for the change. Thanks a lot for your work!

OK :)

sys/netinet/tcp_syncache.c
1507 ↗(On Diff #15647)

OK, but as a different commit.

Basically what you're doing is to loop back the flowid of the received packet - right?

Maybe you could put that in a code comment.

Basically what you're doing is to loop back the flowid of the received packet - right?

Maybe you could put that in a code comment.

Yep, since we don't have inp to loopback the SYN's flowid here. So we use the SYN's flowid directly. OK, will add.

This revision was automatically updated to reflect the committed changes.