Page MenuHomeFreeBSD
Differential D58556

netinet6: Add a definition of struct ip6_hdr_pseudo{} for OCF compatibility.
Needs ReviewPublic
Actions

Authored by bms on Thu, Jul 30, 3:56 PM.
Tags
Referenced Files
F164700278: D58556.id183112.diff
Mon, Aug 3, 6:14 AM
Unknown Object (File)
Sun, Aug 2, 6:23 AM
Unknown Object (File)
Sun, Aug 2, 4:13 AM
Subscribers
ae
glebius
melifaro

Details

Reviewers
glebius
pouria
imp
Summary

This change is intended to address @glebius comments from the original D55663.
ip6_hdr_pseudo{} is referenced by certain OpenBSD OCF related components. I am
using aligned(4) and not packed as urged by the late Hans-Petter Selasky.
Use C99 types and style. We must eat the churn now cross-BSD compatibility
is "Fade to Black".

Put _Static_assert under #ifdef INVARIANTS to not disrupt regular compilation,
as this resides in a commonly included header file.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75295
Build 72178: arc lint + arc unit

Event Timeline

bms created this revision.Thu, Jul 30, 3:56 PM
Herald added subscribers: melifaro, ae. · View Herald TranscriptThu, Jul 30, 3:56 PM
bms requested review of this revision.Thu, Jul 30, 3:56 PM
Harbormaster completed remote builds in B75295: Diff 183112.Thu, Jul 30, 3:56 PM
bms added a comment.Thu, Jul 30, 3:56 PM

Compile tested for amd64 GENERIC.
The next Differential will contain the netipsec/xform_tcp.c refactoring to use ip6_hdr_pseudo{}.

bms added a child revision: D58557: netipsec: Refactor TCP-MD5 shim to use ip6_hdr_pseudo{} for brevity..Thu, Jul 30, 4:09 PM
adrian added a project: network.Fri, Jul 31, 10:01 PM
bms added a comment.Fri, Jul 31, 10:25 PM

The #ifdef INVARIANTS conditional for _Static_assert() is mostly a no-op, because GENERIC enables them via "include "std.debug"".

Revision Contents
Changeset List

PathSize
sys/
netinet6/
18 lines

Diff 183112

View Options

sys/netinet6/ip6_var.h

Loading...