Page MenuHomeFreeBSD
Differential D58557

netipsec: Refactor TCP-MD5 shim to use ip6_hdr_pseudo{} for brevity.
Needs ReviewPublic
Actions

Authored by bms on Jul 30 2026, 4:09 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Aug 28, 9:57 AM
Unknown Object (File)
Fri, Aug 28, 9:57 AM
Unknown Object (File)
Fri, Aug 28, 9:57 AM
Unknown Object (File)
Thu, Aug 27, 7:05 AM
Unknown Object (File)
Tue, Aug 18, 9:22 AM
Unknown Object (File)
Mon, Aug 17, 10:07 PM
Unknown Object (File)
Mon, Aug 17, 10:50 AM
Unknown Object (File)
Mon, Aug 17, 2:33 AM
View All 29 Files
Subscribers
ae
melifaro

Details

Reviewers
glebius
pouria
imp
Summary

This brings xform_tcp.c into line with possible future OCF related imports.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75296
Build 72179: arc lint + arc unit

Event Timeline

bms created this revision.Jul 30 2026, 4:09 PM
Herald added subscribers: melifaro, ae. · View Herald TranscriptJul 30 2026, 4:09 PM
bms requested review of this revision.Jul 30 2026, 4:09 PM
Harbormaster completed remote builds in B75296: Diff 183113.Jul 30 2026, 4:09 PM
bms added a parent revision: D58556: netinet6: Add a definition of struct ip6_hdr_pseudo{} for OCF compatibility..Jul 30 2026, 4:09 PM
bms added a comment.Fri, Jul 31, 9:54 PM

This change has been exercised with bird3. And the tcpdump dissector I forgot I wrote almost ~22.25 years to the day...

In bird.conf, "setkey no" actually means "require external setkey", so use "yes" to save yourself a trip to the SADB when bird will do that for you.
Also, "authentication md5" is now required: [[ https://bird.network.cz/pipermail/bird-users/2025-August/018356.html

sample ]]
adrian added a project: network.Fri, Jul 31, 10:01 PM

Revision Contents
Changeset List

PathSize
sys/
netipsec/
21 lines

Diff 183113

View Options

sys/netipsec/xform_tcp.c

Loading...