uipc_usrreq: revert addition of EMPTYPATH for bindat(2)
ClosedPublic
Actions

Authored by kib on Thu, Jun 4, 5:29 PM.

Details

Reviewers

Commits

rG453968c78d27: uipc_usrreq: revert addition of EMPTYPATH for bindat(2)

Summary

The caller wants the parent vnode, which cannot be provided for emptypath
lookups.

Reported by:    markj
Fixes:  12c590a9abd7 ("bindat(2)/connectat(2): allow implicit EMPTYPATH for unix domain sockets")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Thu, Jun 4, 5:29 PM

Herald added subscribers: ziaee, olce, glebius, imp. · View Herald TranscriptThu, Jun 4, 5:29 PM

kib requested review of this revision.Thu, Jun 4, 5:29 PM

I thought about doing two separate namei()s for bindat, but it is not worth it apparently.

markj accepted this revision.Thu, Jun 4, 5:41 PM

This revision is now accepted and ready to land.Thu, Jun 4, 5:41 PM

Closed by commit rG453968c78d27: uipc_usrreq: revert addition of EMPTYPATH for bindat(2) (authored by kib). · Explain WhyThu, Jun 4, 5:56 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG453968c78d27: uipc_usrreq: revert addition of EMPTYPATH for bindat(2).

Revision Contents
Changeset List

Path

Size

lib/

libsys/

open.2

4 lines

sys/

kern/

uipc_usrreq.c

5 lines

Diff 179227

View Options

lib/libsys/open.2