Page MenuHomeFreeBSD
Differential D57089

apple_bce/vhci: add T2 virtual USB host controller
ClosedPublic
Actions

Authored by seuros on May 19 2026, 10:31 AM.
Tags
Referenced Files
F170007440: D57089.id.diff
Thu, Sep 3, 5:55 AM
F169998847: D57089.id.diff
Thu, Sep 3, 5:31 AM
Unknown Object (File)
Wed, Sep 2, 3:00 AM
Unknown Object (File)
Tue, Sep 1, 11:27 PM
Unknown Object (File)
Tue, Sep 1, 10:07 PM
Unknown Object (File)
Tue, Sep 1, 12:56 AM
Unknown Object (File)
Mon, Aug 31, 2:15 AM
Unknown Object (File)
Sun, Aug 30, 11:32 PM
View All 74 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rG9f90536c74b8: apple_bce/vhci: add T2 virtual USB host controller
Summary

Implements a VHCI driver on top of the BCE transport:

  • Virtual USB bus registration via usb_controller
  • Port discovery and device enumeration
  • Control, interrupt, and bulk endpoint support
  • Firmware event handling with taskqueue
  • Suspend/resume via BCE mailbox

Provides keyboard, trackpad, and Touch Bar access on T2 Macs.

Tested-on: MacBookPro16,2 (A2251), Mac mini 8,1 (A1993)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

seuros created this revision.May 19 2026, 10:31 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 19 2026, 10:31 AM
seuros requested review of this revision.May 19 2026, 10:31 AM
Harbormaster completed remote builds in B73219: Diff 178082.May 19 2026, 10:31 AM
adrian added a parent revision: D57088: apple_bce: add Apple T2 Buffer Copy Engine driver.May 20 2026, 4:37 PM
adrian added projects: apple (x86), drivers.
adrian added a child revision: D57090: bge: read MAC from loader hint for boards without NVRAM/EEPROM.
seuros added a child revision: D56748: asmc: fix asmc_key_dump() page fault on T2 MMIO backend.May 21 2026, 6:44 PM
adrian removed a child revision: D57090: bge: read MAC from loader hint for boards without NVRAM/EEPROM.May 21 2026, 11:47 PM
adrian added a comment.May 30 2026, 1:39 AM

whew this is a whole firmware data pipe and usb controller implementation! this broadly looks okay but i'd like some other usb eyeballs on it.

adrian accepted this revision.May 30 2026, 1:39 AM
adrian added a project: USB.
This revision is now accepted and ready to land.May 30 2026, 1:39 AM
Closed by commit rG9f90536c74b8: apple_bce/vhci: add T2 virtual USB host controller (authored by seuros, committed by adrian). · Explain WhyJun 14 2026, 8:57 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG9f90536c74b8: apple_bce/vhci: add T2 virtual USB host controller.

Revision Contents
Changeset List

PathSize
sys/
conf/
1 line
dev/
apple_bce/
3 lines
87 lines
5 lines
251 lines
4821 lines
usb/
controller/
1 line
modules/
apple_bce/
2 lines

Diff 179757

View Options

sys/conf/files.amd64

Loading...
View Options

sys/dev/apple_bce/apple_bce.h

Loading...
View Options

sys/dev/apple_bce/apple_bce.c

Loading...
View Options

sys/dev/apple_bce/apple_bce_mailbox.c

Loading...
View Options

sys/dev/apple_bce/apple_bce_vhci.h

Loading...
View Options

sys/dev/apple_bce/apple_bce_vhci.c

Loading...
View Options

sys/dev/usb/controller/usb_controller.c

Loading...
View Options

sys/modules/apple_bce/Makefile

Loading...