Page MenuHomeFreeBSD

makeman: switch over to the .lua implementation
ClosedPublic

Authored by kevans on Tue, Apr 21, 3:42 PM.

Details

Summary

Nobody will test it as long as it's not tied into the top-level target,
and we don't really have a good reason not to cut over to it since it
does produce identical results. Switch over but do not remove the old
sh implementation yet, just in case.

Catch up on the one change that's happened in the interim.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.

I'd commit the makeman.lua change first (it LGTM) as we want it to be correct regardless of whether we use it by default or not.

Makefile.inc1
1586

I think this is OK but maybe we should have a ${FLUA} and account for bootstrapped flua?

This revision is now accepted and ready to land.Tue, Apr 21, 3:56 PM
imp added inline comments.
Makefile.inc1
1586

Same. I'd prefer ${FLUA} for good code hygiene, but I don't think it would matter most of the time.

Strip out the functional change- I'm going to commit that now. Use the PATH
approach we use in sysent to search for a flua to use between the system and
the bootstrap tools, just as we did in the sysent target. These two targets
knowingly pretend that STRICTTMPPATH doesn't exist, since they're developer
targets and I didn't want to add friction by requiring bootstrap-tools just to
rebuild these artifacts.

This revision now requires review to proceed.Wed, Apr 22, 2:40 AM
Makefile.inc1
1586

I went with the approach I used with make sysent, since this is another developer target... bootstrap flua is a value-add and to be friendlier to development on other platforms, but I didn't really want the additional complexity of hardcoding the search through TMPPATH and the system at the time for... some reason.

This revision is now accepted and ready to land.Wed, Apr 22, 1:16 PM