LinuxKPI: move hex2bin() from kernel.h to new hex.h
ClosedPublic
Actions

Authored by bz on Tue, Apr 14, 3:31 PM.

Details

Reviewers

emaste
dumbbell

Group Reviewers

linuxkpi

Commits

rG98297ff3cfbb: LinuxKPI: move hex2bin() from kernel.h to new hex.h

Summary

New Linux v7.0 drivers include hex.h. Rather than adding a dummy
header, migrate the kernel.h hex2bin() into hex.h, where it belongs.
Care needs to be taken as the _h2b() helper function is still used by
other bits in kernel.h.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Tue, Apr 14, 3:31 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptTue, Apr 14, 3:31 PM

bz requested review of this revision.Tue, Apr 14, 3:31 PM

Harbormaster completed remote builds in B72200: Diff 175507.Tue, Apr 14, 3:31 PM

bz added a child revision: D56392: LinuxKPI: add default_gfp().Tue, Apr 14, 3:36 PM

LGTM. Was added in deb9bfbd5bcea so copyright statement looks good.

This revision is now accepted and ready to land.Tue, Apr 14, 4:06 PM

In D56391#1290935, @emaste wrote:

LGTM. Was added in deb9bfbd5bcea so copyright statement looks good.

I was wondering about that too but I believe it came from the time when I worked on rtw89 off-clock back then.
There's been a few commits around that date related to rtw89 which weren't Sponsored by:.

dumbbell accepted this revision.Wed, Apr 15, 8:27 PM

Closed by commit rG98297ff3cfbb: LinuxKPI: move hex2bin() from kernel.h to new hex.h (authored by bz). · Explain WhySat, Apr 18, 1:13 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG98297ff3cfbb: LinuxKPI: move hex2bin() from kernel.h to new hex.h.