Paths

Table of Contentst

Differential D55414

chore: replace {0, 0} with {DEV,KOBJ}METHOD_END where appropriate
ClosedPublic
Actions

Authored by ngie on Sat, Feb 21, 6:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 17, 4:32 PM

	Unknown Object (File)
	Mon, Mar 16, 12:32 PM

	Unknown Object (File)
	Mon, Mar 16, 5:58 AM

	Unknown Object (File)
	Wed, Mar 11, 10:30 AM

	Unknown Object (File)
	Mon, Mar 9, 2:30 PM

	Unknown Object (File)
	Thu, Mar 5, 3:50 AM

	Unknown Object (File)
	Thu, Mar 5, 3:15 AM

	Unknown Object (File)
	Wed, Mar 4, 9:32 AM

View All 13 Files

Subscribers

ehem_freebsd_m5p.com

Details

Reviewers

slm
jaeyoon
jhb

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rG0fc6c3f731a2: chore: replace {0, 0} with {DEV,KOBJ}METHOD_END

Summary

Both of the aforementioned macros have been present in FreeBSD
for well over a decade: 2009 for KOBJMETHOD_END; 2011 for
DEVMETHOD_END.

Adapt all hardcoded references of {0, 0} with DEVMETHOD_END
and KOBJMETHOD_END as appropriate. This helps ensure that
future adaptations to drivers following patterns documented
in driver(9) can be made more easily/without issue.

MFC after: 1 week

Test Plan

This change boots on my MacBook13,2 (which uses a limited of drivers touched here).

TODO: a full tinderbox build is in progress.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Sat, Feb 21, 6:22 AM

Owners added a reviewer: Restricted Owners Package.Sat, Feb 21, 6:22 AM

Herald added a reviewer: slm. · View Herald TranscriptSat, Feb 21, 6:22 AM

Herald added a reviewer: jaeyoon. · View Herald Transcript

Herald added subscribers: dab, ae, imp. · View Herald Transcript

ngie requested review of this revision.Sat, Feb 21, 6:22 AM

Harbormaster completed remote builds in B70847: Diff 172364.Sat, Feb 21, 6:22 AM

ngie retitled this revision from chore: replace {0, 0} with {DEVMETHOD,KOBJ}_END where appropriate to chore: replace {0, 0} with {DEVMETHOD,KOBJMETHOD}_END where appropriate.Sat, Feb 21, 6:43 PM

ngie edited the summary of this revision. (Show Details)

ngie added subscribers: jhb, markj.

ngie retitled this revision from chore: replace {0, 0} with {DEVMETHOD,KOBJMETHOD}_END where appropriate to chore: replace {0, 0} with {DEV,KOBJ}METHOD_END where appropriate.Sat, Feb 21, 7:05 PM

ngie edited the test plan for this revision. (Show Details)Sun, Feb 22, 8:13 PM

These all look good to me.

This revision is now accepted and ready to land.Wed, Feb 25, 2:16 AM

Closed by commit rG0fc6c3f731a2: chore: replace {0, 0} with {DEV,KOBJ}METHOD_END (authored by ngie). · Explain WhyThu, Feb 26, 2:10 AM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG0fc6c3f731a2: chore: replace {0, 0} with {DEV,KOBJ}METHOD_END.

I had commits for nearly all of these handy, but I'm lacking a commit bit. Worse I'm starving for committer bandwidth so I end up prioritizing higher-importance commits over cleanup. I've got lots more of this handy in association with D48449, just need someone I can hand it off too.

Revision Contents
Changeset List

Path

Size

sys/

dev/

aacraid/

2 lines

2 lines

acpi_support/

2 lines

acpica/

2 lines

adb/

12 lines

2 lines

2 lines

2 lines

agp/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

aic7xxx/

2 lines

2 lines

2 lines

al_eth/

2 lines

alpm/

2 lines

amdpm/

2 lines

amdsmb/

2 lines

asmc/

2 lines

atkbdc/

2 lines

2 lines

4 lines

axgbe/

4 lines

cfe/

2 lines

cfi/

2 lines

chromebook_platform/

chromebook_platform.c

2 lines

ciss/

2 lines

cxgb/

2 lines

cxgbe/

cxgbei/

2 lines

4 lines

dcons/

2 lines

dpaa/

4 lines

2 lines

2 lines

2 lines

4 lines

dpms/

2 lines

dwc/

2 lines

fb/

2 lines

fdc/

2 lines

2 lines

firewire/

2 lines

2 lines

2 lines

2 lines

flash/

2 lines

flexspi/

2 lines

2 lines

2 lines

2 lines

ftwd/

2 lines

fxp/

2 lines

glxiic/

2 lines

gpio/

dwgpio/

2 lines

hpt27xx/

hpt27xx_osm_bsd.c

2 lines

hptiop/

2 lines

hptnr/

hptnr_osm_bsd.c

2 lines

hyperv/

input/

2 lines

utilities/

2 lines

2 lines

ida/

2 lines

iicbus/

adc/

2 lines

controller/

twsi/

2 lines

2 lines

2 lines

2 lines

2 lines

pwm/

2 lines

sensor/

2 lines

2 lines

2 lines

ipmi/

2 lines

2 lines

4 lines

2 lines

ips/

2 lines

isci/

2 lines

iscsi/

2 lines

iser/

2 lines

isp/

2 lines

itwd/

2 lines

le/

2 lines

2 lines

mfi/

2 lines

2 lines

mge/

2 lines

mlx/

2 lines

mpi3mr/

2 lines

mpr/

2 lines

mvs/

2 lines

2 lines

2 lines

ncthwm/

2 lines

nfsmb/

4 lines

nvd/

2 lines

nvme/

2 lines

2 lines

2 lines

ow/

2 lines

2 lines

2 lines

pbio/

2 lines

pcf/

2 lines

pci/

2 lines

2 lines

2 lines

2 lines

pms/

freebsd/

driver/

ini/

src/

2 lines

powermac_nvram/

powermac_nvram.c

2 lines

ppbus/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

ppc/

2 lines

2 lines

2 lines

2 lines

pst/

2 lines

2 lines

qlnx/

qlnxe/

4 lines

qlxgb/

2 lines

qlxgbe/

2 lines

qlxge/

2 lines

sbni/

2 lines

2 lines

siis/

4 lines

smartpqi/

smartpqi_main.c

2 lines

smbios/

2 lines

smbus/

2 lines

smc/

2 lines

2 lines

2 lines

sound/

macio/

2 lines

4 lines

2 lines

2 lines

2 lines

pci/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

12 lines

spibus/

2 lines

tdfx/

2 lines

ti/

2 lines

tpm/

2 lines

2 lines

uart/

uart_bus_acpi.c

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

uart_dev_lowrisc.c

2 lines

2 lines

uart_dev_mvebu.c

2 lines

uart_dev_pl011.c

2 lines

uart_dev_quicc.c

2 lines

uart_dev_z8530.c

2 lines

ufshci/

3 lines

usb/

controller/

2 lines

input/

4 lines

net/

2 lines

xilinx/

2 lines

Diff 172722

sys/dev/aacraid/aacraid_cam.c

Loading...

sys/dev/aacraid/aacraid_pci.c

Loading...

sys/dev/acpi_support/acpi_asus.c

Loading...

sys/dev/acpica/acpi_video.c

Loading...

sys/dev/adb/adb_bus.c

Loading...

sys/dev/adb/adb_buttons.c

Loading...

sys/dev/adb/adb_kbd.c

Loading...

sys/dev/adb/adb_mouse.c

Loading...

sys/dev/agp/agp_ali.c

Loading...

sys/dev/agp/agp_amd.c

Loading...

sys/dev/agp/agp_amd64.c

Loading...

sys/dev/agp/agp_apple.c

Loading...

sys/dev/agp/agp_ati.c

Loading...

sys/dev/agp/agp_i810.c

Loading...

sys/dev/agp/agp_intel.c

Loading...

sys/dev/agp/agp_nvidia.c

Loading...

sys/dev/agp/agp_sis.c

Loading...

sys/dev/agp/agp_via.c

Loading...

sys/dev/aic7xxx/ahc_isa.c

Loading...

sys/dev/aic7xxx/ahc_pci.c

Loading...

sys/dev/aic7xxx/ahd_pci.c

Loading...

sys/dev/al_eth/al_eth.c

Loading...

sys/dev/alpm/alpm.c

Loading...

sys/dev/amdpm/amdpm.c

Loading...

sys/dev/amdsmb/amdsmb.c

Loading...

sys/dev/asmc/asmc.c

Loading...

sys/dev/atkbdc/atkbd_atkbdc.c

Loading...

sys/dev/atkbdc/atkbdc_isa.c

Loading...

sys/dev/atkbdc/psm.c

Loading...

sys/dev/axgbe/if_axgbe.c

Loading...

sys/dev/cfe/cfe_resource.c

Loading...

sys/dev/cfi/cfi_disk.c

Loading...

sys/dev/chromebook_platform/chromebook_platform.c

Loading...

sys/dev/ciss/ciss.c

Loading...

sys/dev/cxgb/cxgb_main.c

Loading...

sys/dev/cxgbe/cxgbei/icl_cxgbei.c

Loading...

sys/dev/cxgbe/t4_main.c

Loading...

sys/dev/dcons/dcons_crom.c

Loading...

sys/dev/dpaa/bman_fdt.c

Loading...

sys/dev/dpaa/fman_fdt.c

Loading...

sys/dev/dpaa/fman_mdio.c

Loading...

sys/dev/dpaa/if_dtsec_fdt.c

Loading...

sys/dev/dpaa/qman_fdt.c

Loading...

sys/dev/dpms/dpms.c

Loading...

sys/dev/dwc/if_dwc.c

Loading...

sys/dev/fb/fbd.c

Loading...

sys/dev/fdc/fdc.c

Loading...

sys/dev/fdc/fdc_isa.c

Loading...

sys/dev/firewire/if_fwe.c

Loading...

sys/dev/firewire/if_fwip.c

Loading...

sys/dev/firewire/sbp.c

Loading...

sys/dev/firewire/sbp_targ.c

Loading...

sys/dev/flash/cqspi.c

Loading...

sys/dev/flash/flexspi/flex_spi.c

Loading...

sys/dev/flash/mx25l.c

Loading...

sys/dev/flash/n25q.c

Loading...

sys/dev/flash/w25n.c

Loading...

sys/dev/ftwd/ftwd.c

Loading...

sys/dev/fxp/inphy.c

Loading...

sys/dev/glxiic/glxiic.c

Loading...

sys/dev/gpio/dwgpio/dwgpio.c

Loading...

sys/dev/hpt27xx/hpt27xx_osm_bsd.c

Loading...

sys/dev/hptiop/hptiop.c

Loading...

sys/dev/hptnr/hptnr_osm_bsd.c

Loading...

sys/dev/hyperv/input/hv_kbdc.c

Loading...

sys/dev/hyperv/utilities/hv_kvp.c

Loading...

sys/dev/hyperv/utilities/hv_snapshot.c

Loading...

sys/dev/ida/ida_disk.c

Loading...

sys/dev/iicbus/adc/ad7417.c

Loading...

sys/dev/iicbus/controller/twsi/a10_twsi.c

Loading...

sys/dev/iicbus/controller/twsi/twsi.c

Loading...

sys/dev/iicbus/if_ic.c

Loading...

sys/dev/iicbus/iic.c

Loading...

sys/dev/iicbus/iicbb.c

Loading...

sys/dev/iicbus/pwm/adt746x.c

Loading...

sys/dev/iicbus/sensor/ds1631.c

Loading...

sys/dev/iicbus/sensor/ds1775.c

Loading...

sys/dev/iicbus/sensor/max6690.c

Loading...

sys/dev/ipmi/ipmi_acpi.c

Loading...

sys/dev/ipmi/ipmi_isa.c

Loading...

sys/dev/ipmi/ipmi_pci.c

Loading...

sys/dev/ipmi/ipmi_smbus.c

Loading...

sys/dev/ips/ips_disk.c

Loading...

sys/dev/isci/isci.c

Loading...

sys/dev/iscsi/icl_soft.c

Loading...

sys/dev/iser/icl_iser.c

Loading...

sys/dev/isp/isp_pci.c

Loading...

sys/dev/itwd/itwd.c

Loading...

sys/dev/le/if_le_isa.c

Loading...

sys/dev/le/if_le_pci.c

Loading...

sys/dev/mfi/mfi_disk.c

Loading...

sys/dev/mfi/mfi_syspd.c

Loading...

sys/dev/mge/if_mge.c

Loading...

sys/dev/mlx/mlx_disk.c

Loading...

sys/dev/mpi3mr/mpi3mr_pci.c

Loading...

sys/dev/mpr/mpr_pci.c

Loading...

sys/dev/mvs/mvs.c

Loading...

sys/dev/mvs/mvs_pci.c

Loading...

sys/dev/mvs/mvs_soc.c

Loading...

sys/dev/ncthwm/ncthwm.c

Loading...

sys/dev/nfsmb/nfsmb.c

Loading...

sys/dev/nvd/nvd.c

Loading...

sys/dev/nvme/nvme_ahci.c

Loading...

sys/dev/nvme/nvme_pci.c

Loading...

sys/dev/nvme/nvme_sim.c

Loading...

sys/dev/ow/ow.c

Loading...

sys/dev/ow/ow_temp.c

Loading...

sys/dev/ow/owc_gpiobus.c

Loading...

sys/dev/pbio/pbio.c

Loading...

sys/dev/pcf/pcf_isa.c

Loading...

sys/dev/pci/fixup_pci.c

Loading...

sys/dev/pci/hostb_pci.c

Loading...

sys/dev/pci/ignore_pci.c

Loading...

sys/dev/pci/vga_pci.c

Loading...

sys/dev/pms/freebsd/driver/ini/src/agtiapi.c

Loading...

sys/dev/powermac_nvram/powermac_nvram.c

Loading...

sys/dev/ppbus/if_plip.c

Loading...

sys/dev/ppbus/lpt.c

Loading...

sys/dev/ppbus/pcfclock.c

Loading...

sys/dev/ppbus/ppbconf.c

Loading...

sys/dev/ppbus/ppi.c

Loading...

sys/dev/ppbus/pps.c

Loading...

sys/dev/ppc/ppc_acpi.c

Loading...

sys/dev/ppc/ppc_isa.c

Loading...

sys/dev/ppc/ppc_pci.c

Loading...

sys/dev/ppc/ppc_puc.c

Loading...

sys/dev/pst/pst-pci.c

Loading...

sys/dev/pst/pst-raid.c

Loading...

sys/dev/qlnx/qlnxe/qlnx_os.c

Loading...

sys/dev/qlxgb/qla_os.c

Loading...

sys/dev/qlxgbe/ql_os.c

Loading...

sys/dev/qlxge/qls_os.c

Loading...

sys/dev/sbni/if_sbni_isa.c

Loading...

sys/dev/sbni/if_sbni_pci.c

Loading...

sys/dev/siis/siis.c

Loading...

sys/dev/smartpqi/smartpqi_main.c

Loading...

sys/dev/smbios/smbios.c

Loading...

sys/dev/smbus/smb.c

Loading...

sys/dev/smc/if_smc.c

Loading...

sys/dev/smc/if_smc_acpi.c

Loading...

sys/dev/smc/if_smc_fdt.c

Loading...

sys/dev/sound/macio/davbus.c

Loading...

sys/dev/sound/macio/i2s.c

Loading...

sys/dev/sound/macio/onyx.c

Loading...

sys/dev/sound/macio/snapper.c

Loading...

sys/dev/sound/macio/tumbler.c

Loading...

sys/dev/sound/pci/als4000.c

Loading...

sys/dev/sound/pci/atiixp.c

Loading...

sys/dev/sound/pci/cmi.c

Loading...

sys/dev/sound/pci/cs4281.c

Loading...

sys/dev/sound/pci/csapcm.c

Loading...

sys/dev/sound/pci/envy24.c

Loading...

sys/dev/sound/pci/envy24ht.c

Loading...

sys/dev/sound/pci/es137x.c

Loading...

sys/dev/sound/pci/hdsp-pcm.c

Loading...

sys/dev/sound/pci/hdsp.c

Loading...

sys/dev/sound/pci/hdspe-pcm.c

Loading...

sys/dev/sound/pci/hdspe.c

Loading...

sys/dev/sound/pci/ich.c

Loading...

sys/dev/sound/pci/maestro3.c

Loading...

sys/dev/sound/pci/neomagic.c

Loading...

sys/dev/sound/pci/solo.c

Loading...

sys/dev/sound/pci/t4dwave.c

Loading...

sys/dev/sound/pci/vibes.c

Loading...

sys/dev/spibus/spigen.c

Loading...

sys/dev/tdfx/tdfx_pci.c

Loading...

sys/dev/ti/if_ti.c

Loading...

sys/dev/tpm/tpm_acpi.c

Loading...

sys/dev/tpm/tpm_isa.c

Loading...

sys/dev/uart/uart_bus_acpi.c

Loading...

sys/dev/uart/uart_bus_fdt.c

Loading...

sys/dev/uart/uart_bus_isa.c

Loading...

sys/dev/uart/uart_bus_puc.c

Loading...

sys/dev/uart/uart_bus_scc.c

Loading...

sys/dev/uart/uart_dev_imx.c

Loading...

sys/dev/uart/uart_dev_lowrisc.c

Loading...

sys/dev/uart/uart_dev_mu.c

Loading...

sys/dev/uart/uart_dev_mvebu.c

Loading...

sys/dev/uart/uart_dev_pl011.c

Loading...

sys/dev/uart/uart_dev_quicc.c

Loading...

sys/dev/uart/uart_dev_z8530.c

Loading...

sys/dev/ufshci/ufshci_pci.c

Loading...

sys/dev/usb/controller/ehci_fsl.c

Loading...

sys/dev/usb/input/uep.c

Loading...

sys/dev/usb/net/uhso.c

Loading...

sys/dev/xilinx/if_xae.c

Loading...