Page MenuHomeFreeBSD

bus: Provide 32-bit compatibility
Needs ReviewPublic

Authored by des on Fri, Jan 30, 11:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 31, 6:55 PM
Unknown Object (File)
Fri, Jan 30, 9:41 PM
Unknown Object (File)
Fri, Jan 30, 9:11 PM
Unknown Object (File)
Fri, Jan 30, 8:01 PM
Unknown Object (File)
Fri, Jan 30, 5:42 PM
Unknown Object (File)
Fri, Jan 30, 1:56 PM
Subscribers

Details

Reviewers
kib
Summary

Implement 32-bit compatibility for hw.bus.devices and hw.bus.rman.
This allows a 32-bit devinfo(8) to work on a 64-bit kernel.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70229
Build 67112: arc lint + arc unit

Event Timeline

des requested review of this revision.Fri, Jan 30, 11:44 AM
sys/kern/subr_bus.c
5589

Why ignoring the error?
I believe even SBUF_FIXEDLEN would get into an error state on overflow of the buffer.

sys/kern/subr_rman.c
1031

IMO it is worth extracting the same code into a small helper function and calling it twice, instead of copying.

1052

There should be a blank line after the local variables block. There and in several other places in the patch.