Page MenuHomeFreeBSD

bhyve: introduce cancel interface for usb device
Needs ReviewPublic

Authored by aokblast on Aug 5 2025, 9:37 AM.
Tags
None
Referenced Files
F132220294: D51735.diff
Tue, Oct 14, 10:10 PM
Unknown Object (File)
Sun, Oct 12, 10:40 AM
Unknown Object (File)
Fri, Oct 10, 9:52 AM
Unknown Object (File)
Fri, Oct 10, 9:52 AM
Unknown Object (File)
Fri, Oct 10, 9:52 AM
Unknown Object (File)
Fri, Oct 10, 9:52 AM
Unknown Object (File)
Fri, Oct 10, 3:27 AM
Unknown Object (File)
Fri, Oct 10, 3:27 AM
Subscribers

Details

Reviewers
markj
lwhsu
khng
bz
Group Reviewers
bhyve
Summary

When disabling a port, xHCI should allow the backend a chance to cancel
all active transfers before deallocating memory. To support this, we
introduce an interface in UE that lets the backend register a
cancellation callback.

Additionally, this commit allows the backend to populate the tr_softc
field when setting up a transfer in ue_data, enabling context-specific
handling for transfer cancellation and cleanup.

Sponsored By: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 66559
Build 63442: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 27 2025, 1:35 PM

You don't need to call ue_cancel in pci_xhci_cmd_reset_ep()?

This revision now requires review to proceed.Aug 27 2025, 3:31 PM
usr.sbin/bhyve/pci_xhci.c
1201

The rest ep only stop the xfer. However, the parameter of ue_reset pass a whole device instead of a xfer.

1201

Sorry, only clear the stall bit instead of stop whole transfer.

markj added inline comments.
usr.sbin/bhyve/pci_xhci.c
1205

We definitely don't need to be able to return an error from ue_cancel?

This revision is now accepted and ready to land.Aug 27 2025, 3:41 PM
This revision now requires review to proceed.Aug 27 2025, 4:01 PM
usr.sbin/bhyve/pci_xhci.c
738

Or print a warning if it fails.

1203
usr.sbin/bhyve/pci_xhci.c
704

If you move the mutex_destroy to pci_xhci_disable_ep() (which also handles freeing the xfer), you can use this subroutine in pci_xhci_reset_slot() as well.

1206