libusb: implement libusb_set_option

[aokblast]

Summary

Implement libusb_set_option for API compatibility of libusb upstream
The implementation status of each option is as following:

LIBUSB_OPTION_LOG_LEVEL: just like libusb_set_debug
LIBUSB_OPTION_LOG_CB: add callback support for DPRINTF
LIBUSB_OPTION_NO_DEVICE_DISCOVERY: disable initialization of devd and
netlink when register. Also, create no thread when registration of
callback happens.
LIBUSB_OPTION_USE_USBDK: no needed as USBDK is for Windows

[aokblast]

The change about DEBUG_LEVEL to LOG_LEVEL is required to allow set_debug and debug callback works. So add that patch as a parent.

[aokblast]

Fix indent

[kevans]

lib/libusb/libusb10.c

297

log_level seems to be unused in this final version, can it be removed?

1909

style(9) dictates explicit comparison against NULL here

lib/libusb/libusb10_hotplug.c

387

Is there some implication here for no_discovery? Should this be reachable at all if it's set?

[aokblast]

lib/libusb/libusb10_hotplug.c

387

The no_discovery in upstream libusb is utilized when init the context. It will not start any hotplug scan thread if this option is true on the upstream libusb. That means this option is useless after libusb_init is called.

However, our implementation on the hotplug scan thread starts when the hotplug register is called instead of the libusb_init. I think the time point of no_discovery on upstream libusb is tighter because after init it will not work. So our implementation to do check on hotplug handler won't break any usecase of this option as it is expected to be set before init the context and actually hotplug register should be called after init.

[aokblast]

lib/libusb/libusb10.c

297

It is a miss. Sorry, I will update a newer version later.

[aokblast]

Update style inconsistent

[aokblast]

Add manual

[aokblast]

Fix incorrect unlock

[aokblast]

Remove unneeded commit

[emaste]

commit message ought to reference libusb_set_option not just add option

lib/libusb/libusb.h

292

This probably calls for a comment explaining why the value is reused (was already true before your changes)

[aokblast]

lib/libusb/libusb.h

292

The upstream code change in here: https://github.com/libusb/libusb/commit/33d9949921423d0911527e04af8372d320f2489b.

They first use LIBUSB_OPTION_NO_DEVICE_DISCOVERY to replace LIBUSB_OPTION_WEAK_AUTHORITY. Then for the compatibility, they define LIBUSB_OPTION_WEAK_AUTHORITY as a macro again. I would send a different patch about this.

[aokblast]

Rebase to main and remove unrelated changes

[aokblast]

FIxes

[bz]

lib/libusb/libusb.3

25

Please don't forget to update this before pushing.

[adrian]

lib/libusb/libusb10.c

2013

so its returning SUCCESS? Shouldn't this return something else?

[aokblast]

lib/libusb/libusb10.c

2013

In upstream, it returns nothing.